Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review 2017.4 #4

Open
akokai opened this issue May 2, 2017 · 2 comments
Open

Code review 2017.4 #4

akokai opened this issue May 2, 2017 · 2 comments

Comments

@akokai
Copy link
Owner

akokai commented May 2, 2017

This issue can serve as a central thread for any code review on version 2017.4.
@mahmoud
Copy link

mahmoud commented Oct 28, 2017

In the end it was easier to simply review this in a markdown file next to the files themselves. Here's a gist with my initial review notes: https://gist.github.com/mahmoud/7ce4ea6557dd52ff28f2f31ccab6b086

In summary, it's a solid foundational codebase with very readable documentation. Good work!

@akokai
Copy link
Owner Author

akokai commented Nov 13, 2017

Thank you for taking the time to review this project, @mahmoud! You've given us lots of great suggestions to work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mahmoud @akokai