-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using css-modules in meteor package #41
Comments
The options are pulled from the project's package.json file. The Meteor build process does supply the ability to detect when it is being run in a package, so I'd need introduce a new setting (probably |
That sounds great! I assume that would all be in the app's package.json file? |
From what I know of If no css modules config is found inside the package, should it default to the default options or to the options specified in the app's package.json? I'm currently leaning strongly towards the latter, since all the package author would have to is define the following in order to prevent that:
|
I thought the I fully agree, I like your idea of merging the two as you mentioned above. I feel it would be excess config to do otherwise, and if it's easy enough to prevent with Big +1. |
I try to make my own package with 'nathantreid:css-modules'.
What should I do to use css-modules in own package ? |
@hisayan I'll publish the fix for that error later today. |
@hisayan you should be good now with v2.2.1. |
Thanks. It was solved. |
I have a problem. It is ok that the css file in my own package. thanks. This is my simple sample code.
it works fine. but interrupt this process ([ctrl]+c) and restart.
The css file 'flexboxgrid' in node_modules in my package is not load with your css-loader. but
It works fine. Is there any mistake in my code ? and I want to use react-flexbox-grid in my own package finally. |
@hisayan I should have time to look at that this weekend. |
@hisayan This may be due to the way Meteor is hardcoding CSS support. in npm packages. I'll do some more digging but right now it's not looking too good until Meteor opens up the .css extension. |
I appreciate it. |
Is this related to why this package is not working in Meteor? https://github.com/roylee0704/react-flexbox-grid |
When using css modules in a package:
myapp/packages/mypackage/package.js
Where is it getting it's package options from? the root project's package.json file? Could it be possible to define different package options such as extensions or ignorePaths that apply only to the package?
The text was updated successfully, but these errors were encountered: