return 0 for getDelegateRewards if voter didn't vote in the screening stage

[MikeHathaway]

Description of change

High level

• return 0 for getDelegateRewards if voter didn't vote in the screening stage

Description of bug or vulnerability and solution

• getDelegateReward returned incorrect values if called when a voter didn't vote in the screening stage.
• https://github.com/Fixed-Point-Solutions/ajna-PositionManager-RewardsManager/issues/24

[grandizzy]

shouldn't this check be done inside _getDelegateReward function so to be applied for all scenarios where it is called?

[grandizzy]

I personally prefer using

if (voter.screeningVotesCast != 0) {
  rewards_ = 
}

[ith-harvey]

Although I'm not opinionated about this change, it's a pattern we have been following in the contracts repo and therefore I agree with @grandizzy .

[MikeHathaway]

shouldn't this check be done inside _getDelegateReward function so to be applied for all scenarios where it is called?

Did it this way for a couple of reasons - this would be the minimal amount of changes, and also, the claim approach should revert instead of returning 0, so we would have to create branching logic to handle claim vs get calls to _getDelegateReward

[grandizzy]

shouldn't this check be done inside _getDelegateReward function so to be applied for all scenarios where it is called?

Did it this way for a couple of reasons - this would be the minimal amount of changes, and also, the claim approach should revert instead of returning 0, so we would have to create branching logic to handle claim vs get calls to _getDelegateReward

makes sense, thanks

[EdNoepel]

LGTM

[ith-harvey]

LGTM

[prateek105]

LGTM