Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML multiline highlighting should ignore colon #3309

Closed
letmaik opened this issue Jun 5, 2017 · 3 comments
Closed

YAML multiline highlighting should ignore colon #3309

letmaik opened this issue Jun 5, 2017 · 3 comments

Comments

@letmaik
Copy link

letmaik commented Jun 5, 2017

after_success:
  - >
    if [[ "`git log -n 1 --pretty=format:'%d'`" =~ "tag: v" ]]; then
       pip install twine ;
       ...

GitHub rendering 05/06/2017:
image

Everything in the > multiline block should be highlighted the same color, but it seems that the : gets picked up and changes the highlighting. I haven't checked if this is fixed in a newer ACE version other than the one used by GitHub.

@nightwing
Copy link
Member

1168fdd fixes this issue in ace, but AFAIK ace is not used for highlighting code in github comments.

@letmaik
Copy link
Author

letmaik commented Jun 7, 2017

You're right, I got mislead somehow. For YAML, GitHub uses https://github.com/atom/language-yaml for highlighting (from this list: https://github.com/github/linguist/blob/master/vendor/README.md).

@letmaik
Copy link
Author

letmaik commented Jun 7, 2017

Just for reference, the original grammar which is used by atom and also GitHub (and VS Code) has an issue for that filed already: textmate/yaml.tmbundle#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants