Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Edits to the settings.py file #4031

Merged
merged 1 commit into from
Dec 10, 2024
Merged

website: Edits to the settings.py file #4031

merged 1 commit into from
Dec 10, 2024

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Dec 10, 2024

Description

  • Edited settings file for testing on staging

Summary by CodeRabbit

  • New Features

    • Simplified configuration for CORS and CSRF settings, now dynamically parsed from environment variables.
    • Media file storage now consistently uses Cloudinary, removing previous distinctions based on environment.
  • Bug Fixes

    • Hardcoded DEBUG setting to True, streamlining control flow in the configuration.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.73%. Comparing base (717df35) to head (4bfbb94).
Report is 18 commits behind head on staging.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           staging    #4031   +/-   ##
========================================
  Coverage    11.73%   11.73%           
========================================
  Files          114      114           
  Lines        15331    15331           
  Branches       319      319           
========================================
  Hits          1799     1799           
  Misses       13532    13532           

Copy link
Contributor

website changes in this PR available for preview here

@Baalmart Baalmart merged commit aff0803 into staging Dec 10, 2024
52 checks passed
@Baalmart Baalmart deleted the website-trigger-3 branch December 10, 2024 10:27
@Baalmart Baalmart mentioned this pull request Dec 10, 2024
3 tasks
Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request modifies the settings.py file of a Django project, primarily altering the DEBUG setting to a hardcoded value of True. It removes previous conditional logic for CORS and CSRF settings, replacing static lists with environment variable parsing. Additionally, the configuration for media file storage is simplified by always using Cloudinary's storage solution, eliminating distinctions based on the DEBUG setting. These changes streamline the configuration process by reducing complexity and enhancing the reliance on environment variables.

Changes

File Path Change Summary
src/website/core/settings.py - Hardcoded DEBUG = True.
- Updated CORS_ALLOWED_ORIGINS, CORS_ORIGIN_REGEX_WHITELIST, and CSRF_TRUSTED_ORIGINS to use parse_env_list.
- Set DEFAULT_FILE_STORAGE to use Cloudinary's storage solution, removing conditional logic.

Possibly related PRs

Suggested reviewers

  • Baalmart
  • Psalmz777

🌟 In the land of code where settings reside,
The DEBUG is set, no more to hide.
CORS and CSRF now dance with ease,
Environment variables bring a fresh breeze.
Cloudinary's storage, a seamless delight,
Configurations streamlined, all set for flight! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 415e393 and 4bfbb94.

📒 Files selected for processing (1)
  • src/website/core/settings.py (3 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants