Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to production #2272

Merged
merged 20 commits into from
Oct 13, 2023
Merged

move to production #2272

merged 20 commits into from
Oct 13, 2023

Conversation

Baalmart
Copy link
Contributor

@Baalmart Baalmart commented Oct 13, 2023

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2272 (6fa4bf2) into master (3befa46) will decrease coverage by 2.75%.
Report is 219 commits behind head on master.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
- Coverage   35.07%   32.32%   -2.75%     
==========================================
  Files         165      141      -24     
  Lines       24506    21684    -2822     
  Branches     2407     2407              
==========================================
- Hits         8595     7010    -1585     
+ Misses      15788    14551    -1237     
  Partials      123      123              
Files Coverage Δ
src/auth-service/config/constants.js 7.07% <ø> (ø)
src/auth-service/utils/email.msgs.js 3.50% <ø> (ø)
src/device-registry/utils/test/ut_translate.js 100.00% <ø> (+17.39%) ⬆️
src/device-registry/controllers/create-grid.js 2.60% <0.00%> (ø)
src/device-registry/utils/create-activity.js 21.02% <0.00%> (+0.09%) ⬆️
src/device-registry/routes/v2/grids.js 33.07% <33.33%> (+<0.01%) ⬆️
src/device-registry/utils/generate-filter.js 64.15% <84.61%> (-0.29%) ⬇️

... and 25 files with indirect coverage changes

@Baalmart Baalmart changed the title move to production [work in progress] move to production Oct 13, 2023
@Baalmart Baalmart marked this pull request as draft October 13, 2023 02:41
@Baalmart
Copy link
Contributor Author

Hi @BenjaminSsempala , I have merged the PR but I notice that the merged PR did not have any deploy preview? Can you crosscheck to find out WHY?

I have gone ahead to make the PR a draft PR to prevent us introducing any problems in production.

@Baalmart Baalmart changed the title [work in progress] move to production move to production Oct 13, 2023
@Baalmart Baalmart marked this pull request as ready for review October 13, 2023 05:46
@Baalmart Baalmart merged commit f9729d5 into master Oct 13, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants