move to production #2181
Merged
move to production #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Baalmart
commented
Sep 13, 2023
•
Baalmart
commented
- Adding missing mongoose Import to models #2180
- Translations to French for health tips from the API #2159
- Fix Translate on Staging #2182
- Followup Pr for translate functionality #2184
- Fix Failing task in AirQo Bam DAG #2183
Adding missing mongoose Import to models
Translations to French for health tips from the API
Baalmart
commented
Sep 14, 2023
| @@ -589,6 +591,16 @@ const createEvent = { | |||
| filter, | |||
| page, | |||
| }); | |||
| if (language !== undefined && constants.ENVIRONMENT === "STAGING ENVIRONMENT") { | |||
| let data = responseFromListEvents.data[0].data; | |||
| for (const event of data) { | |||
There was a problem hiding this comment.
Hi @BenjaminSsempala , this logic is still confusing me a little bit :)......
Especially the part of manipulating a const variable....and the logical flow of things is bit confusing!
Can we do this translation from somewhere else within the create-health-tips use case and minimise changes to this particular util function?
There was a problem hiding this comment.
@Baalmart The translation is also in the create-health-tips, however The tips in the mobile app come along with the measurements using the /events endpoint.
Followup Pr for translate functionality
Baalmart
commented
Sep 15, 2023
| filter, | ||
| limit, | ||
| skip, | ||
| }); | ||
| if (language !== undefined) { |
There was a problem hiding this comment.
Now, this logic is easier to understand than the one inside the create-events util. :) @BenjaminSsempala
Fix Failing task in AirQo Bam DAG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.