Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent Model Initialization in UnknownIP Model #3921

Open
coderabbitai bot opened this issue Nov 25, 2024 · 0 comments
Open

Inconsistent Model Initialization in UnknownIP Model #3921

coderabbitai bot opened this issue Nov 25, 2024 · 0 comments
Assignees
@Baalmart

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2024

An inconsistency has been identified in the model initialization within src/auth-service/models/UnknownIP.js. The file uses both getModelByTenant(dbTenant, "UnknownIP", UnknownIPSchema) and direct mongoose model initialization with mongoose.model("UnknownIPs"), which could lead to tenant isolation issues.\n\nPR URL: https://github.com/airqo-platform/AirQo-api/pull/3919\nComment URL: https://github.com/airqo-platform/AirQo-api/pull/3919#discussion_r1857373937\n\nRequested by @Baalmart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Baalmart Baalmart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Baalmart