Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving from zlib to minizlib #57

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

makrsmark
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

@makrsmark makrsmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will see if this works against the SPA before merging this PR

@@ -59,5 +59,5 @@ test('v1, compressed, acars, incomplete', () => {
expect(decodeResult.message.data.acars.label).toBe('H1');
expect(decodeResult.message.data.acars.sublabel).toBe('DF');
expect(decodeResult.message.data.acars.mfi).toBe(undefined);
expect(decodeResult.message.data.acars.text).toBe(undefined);
expect(decodeResult.message.data.acars.text).toBe('A350,000130,1,1,TB000000/REP019,24,02;H01,019,24,02,6400,00175,B-18910,3,0,03,11,19,08,07,01,070/H02,NZAA YBBN,CAL054 ,S');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andermatt64 added you because i wanted to make sure this is ok... i think it is, but i'm not going to pretend to know this code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makrsmark
Copy link
Collaborator Author

makrsmark commented Mar 18, 2024

used npm link to have a local override - looks like it's still the same issue, not a fix

Module not found: Error: Can't resolve 'zlib' in 'C:\Users\marks\code\acars-decoder-typescript\node_modules\minizlib'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "zlib": require.resolve("browserify-zlib") }'
        - install 'browserify-zlib'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "zlib": false }

Will keep open as the partial decoding might be good, but if this is closed, i won't be sad

@kevinelliott
Copy link
Contributor

used npm link to have a local override - looks like it's still the same issue, not a fix

Module not found: Error: Can't resolve 'zlib' in 'C:\Users\marks\code\acars-decoder-typescript\node_modules\minizlib'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
        - add a fallback 'resolve.fallback: { "zlib": require.resolve("browserify-zlib") }'
        - install 'browserify-zlib'
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.fallback: { "zlib": false }

Ahh worth a try. Hopefully we can figure that out sooner than later.

@kevinelliott
Copy link
Contributor

@makrsmark What do you think? Is this still up to date? :)

@makrsmark
Copy link
Collaborator Author

I think it's useful as it seems to decode a little more. If we want it, I can fix conflicts. Otherwise, we can just close without merging.

@kevinelliott
Copy link
Contributor

I'd say we merge it (after resolving conflicts), if you still think there is value here.

@makrsmark makrsmark merged commit 31ca9d3 into airframesio:master Jul 29, 2024
3 checks passed
@makrsmark makrsmark deleted the minizlib branch July 29, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants