Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile error "/os_dep/linux/recv_linux.c" #89

Open
brandontict opened this issue Dec 27, 2021 · 11 comments
Open

Compile error "/os_dep/linux/recv_linux.c" #89

brandontict opened this issue Dec 27, 2021 · 11 comments

Comments

@brandontict
Copy link

Running Kali ,
uname -a Linux kt0p 5.14.0-kali4-amd64 #1 SMP Debian 5.14.16-1kali1 (2021-11-05) x86_64 GNU/Linux
Kali is recently updated .

Compiling rtl8814au version 5.8.5.1.

Fatal error while compiling .

/pentest/8814au/rtl8814au/os_dep/linux/recv_linux.c: In function ‘napi_recv’: /pentest/8814au/rtl8814au/os_dep/linux/recv_linux.c:358:55: error: ‘GRO_DROP’ undeclared (first use in this function) 358 | if (rtw_napi_gro_receive(&padapter->napi, pskb) != GRO_DROP) | ^~~~~~~~ /pentest/8814au/rtl8814au/os_dep/linux/recv_linux.c:358:55: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [/usr/src/linux-headers-5.14.0-kali4-common/scripts/Makefile.build:276: /pentest/8814au/rtl8814au/os_dep/linux/recv_linux.o] Error 1 make[2]: *** [/usr/src/linux-headers-5.14.0-kali4-common/Makefile:1882: /pentest/8814au/rtl8814au] Error 2 make[1]: *** [/usr/src/linux-headers-5.14.0-kali4-common/Makefile:232: __sub-make] Error 2 make[1]: Leaving directory '/usr/src/linux-headers-5.14.0-kali4-amd64' make: *** [Makefile:2353: modules] Error 2

@zhouxv
Copy link

zhouxv commented Jan 18, 2022

kernel 5.13
same problem

@averissimo
Copy link

There are pull requests that fix this issue, I personally use #64, but #82 from @alxgnon might be better for 5.15 compatibility

@zhouxv
Copy link

zhouxv commented Jan 18, 2022 •
edited
Loading

There are pull requests that fix this issue, I personally use #64, but #82 from @alxgnon might be better for 5.15 compatibility

#89 from @brandontict works for me. Ubunut 20.04 LTS / kenel 5.13.0-25-generic
3q

@brandontict
Copy link
Author

brandontict commented Jan 20, 2022 •
edited
Loading

There are pull requests that fix this issue, I personally use #64, but #82 from @alxgnon might be better for 5.15 compatibility
Thanks for the feedback.

I am not too familiar with git, So having issues applying that pull request.

I've went to the request #82 , clicked on code and copied gh pr checkout 82 . into terminal, within the folder I had cloned for his repo

Also tried

git pull origin d2ed7cff6d760dab4b85c819f3ff0b3aca9d2f35

with no luck.

I make sure that I am within the folder that I cloned from this repo when attempting to use these pull requests.

@alxgnon
Copy link

alxgnon commented Jan 20, 2022

@brandontict try this instead:

git remote add alxgnon https://github.com/alxgnon/rtl8814au.git
git fetch alxgnon
git checkout --track alxgnon/fix_5.15

@boeboe
Copy link

boeboe commented Jan 27, 2022

@alxgnon problem still persists.

# :~/Downloads$ git clone https://github.com/aircrack-ng/rtl8814au
Cloning into 'rtl8814au'...
remote: Enumerating objects: 1121, done.
remote: Counting objects: 100% (1121/1121), done.
remote: Compressing objects: 100% (720/720), done.
remote: Total 1121 (delta 546), reused 944 (delta 385), pack-reused 0
Receiving objects: 100% (1121/1121), 2.97 MiB | 3.75 MiB/s, done.
Resolving deltas: 100% (546/546), done.
# :~/Downloads$ cd rtl8814au/
# :~/Downloads/rtl8814au$ git remote add alxgnon https://github.com/alxgnon/rtl8814au.git
# :~/Downloads/rtl8814au$ git fetch alxgnon
remote: Enumerating objects: 7, done.
remote: Counting objects: 100% (7/7), done.
remote: Compressing objects: 100% (1/1), done.
remote: Total 4 (delta 3), reused 4 (delta 3), pack-reused 0
Unpacking objects: 100% (4/4), 582 bytes | 194.00 KiB/s, done.
From https://github.com/alxgnon/rtl8814au
* [new branch]      fix_5.15   -> alxgnon/fix_5.15
* [new branch]      main       -> alxgnon/main
* [new branch]      v5.8.5.1   -> alxgnon/v5.8.5.1
# :~/Downloads/rtl8814au$ git checkout --track alxgnon/fix_5.15
Branch 'fix_5.15' set up to track remote branch 'fix_5.15' from 'alxgnon'.
Switched to a new branch 'fix_5.15'
# :~/Downloads/rtl8814au$ make
make ARCH=x86_64 CROSS_COMPILE= -C /lib/modules/5.13.0-1008-intel/build M=/home/boeboe/Downloads/rtl8814au  modules
make[1]: Entering directory '/usr/src/linux-headers-5.13.0-1008-intel'
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_cmd.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_security.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_debug.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_io.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_ioctl_query.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_ioctl_set.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_ieee80211.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_mlme.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_mlme_ext.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_mi.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_wlan_util.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_vht.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_pwrctrl.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_rf.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_chplan.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_recv.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_sta_mgt.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_ap.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/mesh/rtw_mesh.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/mesh/rtw_mesh_pathtbl.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/mesh/rtw_mesh_hwmp.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_xmit.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_p2p.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_rson.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_tdls.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_br_ext.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_iol.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_sreset.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_btcoex_wifionly.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_btcoex.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_beamforming.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_odm.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_rm.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_rm_fsm.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/rtw_rm_util.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/core/efuse/rtw_efuse.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/os_dep/osdep_service.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/os_dep/linux/os_intfs.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/os_dep/linux/usb_intf.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/os_dep/linux/usb_ops_linux.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/os_dep/linux/ioctl_linux.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/os_dep/linux/xmit_linux.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/os_dep/linux/mlme_linux.o
  CC [M]  /home/boeboe/Downloads/rtl8814au/os_dep/linux/recv_linux.o
/home/boeboe/Downloads/rtl8814au/os_dep/linux/recv_linux.c: In function ‘napi_recv’:
/home/boeboe/Downloads/rtl8814au/os_dep/linux/recv_linux.c:358:55: error: ‘GRO_DROP’ undeclared (first use in this function)
  358 |    if (rtw_napi_gro_receive(&padapter->napi, pskb) != GRO_DROP)
      |                                                       ^~~~~~~~
/home/boeboe/Downloads/rtl8814au/os_dep/linux/recv_linux.c:358:55: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [scripts/Makefile.build:281: /home/boeboe/Downloads/rtl8814au/os_dep/linux/recv_linux.o] Error 1
make[1]: *** [Makefile:1874: /home/boeboe/Downloads/rtl8814au] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.13.0-1008-intel'
make: *** [Makefile:2353: modules] Error 2
# :~/Downloads/rtl8814au$ uname -r
5.13.0-1008-intel

@alxgnon
Copy link

alxgnon commented Jan 27, 2022

My patch is for kernel 5.15 and up.

@aranthorne
Copy link

aranthorne commented Jan 30, 2022 •
edited
Loading

I ran into the compile error also and modified the line 358 of the rtl8814au/os_dep/linux/recv_linux.c to
if (rtw_napi_gro_receive(&padapter->napi, pskb))

It compiles successfully for the 5.13.0-27-generic kernel after that change is made.
Then completed as normally and the A7000 is performing wonderfully well.

@boeboe boeboe mentioned this issue Feb 2, 2022
Open
@brandontict
Copy link
Author

brandontict commented Feb 3, 2022 •
edited
Loading

I too am running into the same compile issue, after adding @aixgnon commit, issue was fixed.

Until I updated my machine , Since I already had the module compiled, I ran " make install " . Still modprobe doesn't see 8814au.ko .

I go to re compile, with alxgnon/fix_5.15 , and compile now errors out with a new issue.

/pentest/8814au/8814au/core/rtw_br_ext.c:20:18: fatal error: net/ipx.h: No such file or directory 20 | #include <net/ipx.h> | ^~~~~~~~~~~ compilation terminated. make[2]: *** [/usr/src/linux-headers-5.15.0-kali3-common/scripts/Makefile.build:282: /pentest/8814au/8814au/core/rtw_br_ext.o] Error 1

@u2mejc
Copy link

u2mejc commented Oct 26, 2022

There are some other PRs that also fix this, but I happened on this issue / fix first. I had this issue on a fresh install of (K)Ubuntu/22.04, alxgnon's patch plus aranthorne's comment worked for me.

These steps, after fresh install, worked for me:

# clone and cd into this repo, then checkout alxgnon's PR
git fetch origin pull/82/head:alxgnon/fix_5.15
git checkout alxgnon/fix_5.15

# Remove undeclared GRO_DROP reference
sed -i'' 's/ \!= GRO_DROP//g' os_dep/linux/recv_linux.c

sudo apt-get update && sudo apt-get upgrade
# Restarted to load kernel changes
sudo apt-get install linux-headers-$(uname -r) make gcc -y
make clean
make
sudo make install

@wp-coin
Copy link

wp-coin commented Jan 18, 2023

the 5.17 patch does not work on 5.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@averissimo @boeboe @alxgnon @brandontict @u2mejc @zhouxv @wp-coin @aranthorne