Bulk Load CDK: Remove interface from scope provider and migrate tests #51019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tryangul
reviewed
Jan 9, 2025
| @@ -54,8 +54,7 @@ interface WrappedTask<T : Task> : Task { | |||
|
|
|||
| @Singleton | |||
| @Secondary | |||
There was a problem hiding this comment.
We should be able to get rid of the @secondary now right?
tryangul
reviewed
Jan 9, 2025
|
|
||
| @Singleton | ||
| @Primary | ||
| @Requires(env = ["MockScopeProvider"]) |
There was a problem hiding this comment.
I think there's another instance of this string literal somewhere that we can 🔪
tryangul
approved these changes
Jan 9, 2025
johnny-schmidt
deleted the
jschmidt/load-cdk/remove-interfaces-task-scope-provider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Small piece of remove interfaces / migrate tests to mockk