🐛 Source Instagram: Remove deprecated metrics for media_insights and user_insights #51018
+60
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
maxi297
force-pushed
the
zendesk-issue-9888/remove-deprecated-metrics
branch
from
1847c17 to
7456082
Compare
octavia-squidington-iii
removed
the
area/documentation
octavia-squidington-iii
added
the
area/documentation
maxi297
commented
Jan 9, 2025
| @@ -33,10 +33,6 @@ | |||
| "description": "The number of times users have saved the media.", | |||
| "type": ["null", "integer"] | |||
| }, | |||
| "video_views": { | |||
There was a problem hiding this comment.
Probably not useful because the media_insights stream uses the schema inlined in the manifest but I updated both just in case
ChristoGrab
approved these changes
Jan 9, 2025
|
I'm going to force merge as https://storage.cloud.google.com/airbyte-ci-reports-multi/airbyte-ci/connectors/test/pull_request/zendesk-issue-9888_remove-deprecated-metrics/1736456434/f629b56ec8a6106ea6d25257a8657a7f125cd9e3/source-instagram/3.1.1/output.html seems to indicate that all testing is fine although the CI check is blocked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
media_insights and user_insights are failing because we are requesting for metrics that were deprecated yesterday. For more information:
How
Removing those fields
User Impact
Syncs should start being successful again although the deprecated metrics won't be available anymore.
Can this PR be safely reverted and rolled back?
... as it would make media_insights and user_insights fail again