Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aip.updated model property is not consistent with markdown front-matter #95

Open
eljobe opened this issue Sep 5, 2023 · 1 comment
Open

Comments

@eljobe
Copy link

eljobe commented Sep 5, 2023

For example, look at the latest change to aip-162: aip-dev/google.aip.dev@e487231

In that change the author updated the updated field on line 3 of 0162.md

But, the had no impact on the date displayed in the generated HTML.

image

It looks like the logic of the update property in aip.py is to look for index 0 of the changelog and fall back to the created date if there isn't a changelog.

Perhaps the order of the changelog entries is upside down? Because, the author also updated the changelong in the same change and it still looks like the logic fell back to the created time.

@ryanmcginnis
Copy link

This seems important to fix soon. It gives the incorrect impression that the information is out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants