Skip to content

Commit 56b915a

Browse files
authored
[fix] Resolve issue with new runs after tracking queue shutdown (#3134)
1 parent b172492 commit 56b915a

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Changelog
22

3-
## 3.19.3
3+
## 3.19.3
4+
- Resolve issue with new runs after tracking queue shutdown (mihran113)
45
- Reset base path when opening new tabs (mihran113)
56

67
## 3.19.2 Mar 22, 2024

aim/ext/transport/client.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,7 @@
3232
class Client:
3333
_thread_local = threading.local()
3434

35-
_queue = RequestQueue(
36-
'remote_tracker',
37-
max_queue_memory=os.getenv(AIM_CLIENT_QUEUE_MAX_MEMORY, 1024 * 1024 * 1024),
38-
retry_count=DEFAULT_RETRY_COUNT,
39-
retry_interval=DEFAULT_RETRY_INTERVAL
40-
)
41-
4235
def __init__(self, remote_path: str):
43-
# temporary workaround for M1 build
44-
4536
self._id = str(uuid.uuid4())
4637
if remote_path.endswith('/'):
4738
remote_path = remote_path[:-1]
@@ -58,6 +49,12 @@ def __init__(self, remote_path: str):
5849
self._tracking_endpoint = f'{self.remote_path}/tracking'
5950
self.connect()
6051

52+
self._queue = RequestQueue(
53+
f'remote_tracker_{self._id}',
54+
max_queue_memory=os.getenv(AIM_CLIENT_QUEUE_MAX_MEMORY, 1024 * 1024 * 1024),
55+
retry_count=DEFAULT_RETRY_COUNT,
56+
retry_interval=DEFAULT_RETRY_INTERVAL
57+
)
6158
self._heartbeat_sender = HeartbeatSender(self)
6259
self._heartbeat_sender.start()
6360
self._thread_local.atomic_instructions = {}

aim/ext/transport/request_queue.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def register_task(self, client, task_f, *args):
3333
self._client = weakref.ref(client)
3434

3535
if self._shutdown:
36-
logger.debug('Cannot register task: rpc task queue is stopped.')
36+
logger.debug('Cannot register task: task queue is stopped.')
3737
return
3838

3939
arg_size = self._calculate_size(args)
@@ -100,7 +100,7 @@ def wait_for_finish(self):
100100
def stop(self):
101101
pending_task_count = self._queue.qsize()
102102
if pending_task_count:
103-
logger.warning(f'Processing {pending_task_count} pending tasks in the rpc queue \'{self._name}\'... '
103+
logger.warning(f'Processing {pending_task_count} pending tasks in the task queue \'{self._name}\'... '
104104
f'Please do not kill the process.')
105105
self._queue.join()
106106
logger.debug('No pending tasks left.')

0 commit comments

Comments
 (0)