-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @Async annotation for the commands/arguments #401
Comments
Hello, I hope you're all doing well! |
I would confirm that no one is working on this "issue". Truthfully, I have not put any thought into what this looks like to implement. Or anything else about it. |
It would be helpful if you could provide a description of the issue! @vortexthedev @chickeneer |
The title of issue is saying everything |
Add @async annotation, so we can get rid of non-async database queries for example in the registered contexts (params). |
Could you implement next methods? (If any of registered contexts are async, then the whole command execution will be off main thread by using runTaskAsync?)
Add @async annotation so we can select any commands besides the params to be async. |
No, there are some open things:
Feel free to make a PoC by forking acf yourself and try to implement such a feature. If anyone could implement that in a few minutes we would already added it as a feature to acf. But such a complex idea should be implemented correctly and the required time for this is huge. |
If there is any parameters that are required to be run async, or the command/subcommand has @async annotation, then the whole command process (Command#execute) will be ran through Scheduler#runTaskAsync(). |
No description provided.
The text was updated successfully, but these errors were encountered: