Review

Author: danielhollas

src/aiida/cmdline/commands/cmd_code.py

@@ -85,6 +85,7 @@ def set_code_builder(ctx, param, value):
     """Set the code spec for defaults of following options."""
     from aiida.orm.utils.builders.code import CodeBuilder
 
+    # TODO(danielhollas): CodeBuilder is deprecated, rewrite this somehow?
     with warnings.catch_warnings(record=True):
         ctx.code_builder = CodeBuilder.from_code(value)
     return value
@@ -125,6 +126,7 @@ def setup_code(ctx, non_interactive, **kwargs):
     if kwargs['input_plugin']:
         kwargs['input_plugin'] = kwargs['input_plugin'].name
 
+    # TODO(danielhollas): CodeBuilder is deprecated
     with warnings.catch_warnings(record=True):
         code_builder = CodeBuilder(**kwargs)
 
@@ -227,10 +229,16 @@ def show(code):
     table.append(['PK', code.pk])
     table.append(['UUID', code.uuid])
     table.append(['Type', code.entry_point.name])
+    # TODO(danielhollas): This code is a bit too clever, make it simpler!
+    # It generates warnings because it accessess deprecated attributes such as
+    # Code.repository_metadata -> Code.base.repository.metadata
+    # Code.attributes -> Code.base.attributes.all
+    # Code.extras -> Code.base.extras.all
+    # Also also, the blanket `except AttributeError` is evil and can hide bugs.
     for key in code.Model.model_fields.keys():
         try:
-            with warnings.catch_warnings(record=True):
-                table.append([key.capitalize().replace('_', ' '), getattr(code, key)])
+            # with warnings.catch_warnings(record=True):
+            table.append([key.capitalize().replace('_', ' '), getattr(code, key)])
         except AttributeError:
             continue
     if is_verbose():

tests/transports/test_all_plugins.py

@@ -33,6 +33,8 @@
 # TODO : test for exotic cases of copy with source = destination
 # TODO : silly cases of copy/put/get from self to self
 
+CHDIR_WARNING = re.escape('`chdir()` is deprecated and will be removed')
+
 
 @pytest.fixture(scope='function')
 def tmp_path_remote(tmp_path_factory):
@@ -323,7 +325,7 @@ def test_chdir_to_empty_string(custom_transport):
         return
 
     with custom_transport as transport:
-        with pytest.warns(AiidaDeprecationWarning, match=re.escape('`chdir()` is deprecated and will be removed')):
+        with pytest.warns(AiidaDeprecationWarning, match=CHDIR_WARNING):
             new_dir = transport.normalize(os.path.join('/', 'tmp'))
             transport.chdir(new_dir)
             transport.chdir('')
@@ -988,15 +990,15 @@ def test_exec_pwd(custom_transport, tmp_path_remote):
         subfolder = """_'s f"#"""  # A folder with characters to escape
         subfolder_fullpath = os.path.join(location, subfolder)
 
-        with pytest.warns(AiidaDeprecationWarning, match=re.escape('`chdir()` is deprecated and will be removed')):
+        with pytest.warns(AiidaDeprecationWarning, match=CHDIR_WARNING):
             transport.chdir(location)
         if not transport.isdir(subfolder):
             # Since I created the folder, I will remember to
             # delete it at the end of this test
             transport.mkdir(subfolder)
 
             assert transport.isdir(subfolder)
-            with pytest.warns(AiidaDeprecationWarning, match=re.escape('`chdir()` is deprecated and will be removed')):
+            with pytest.warns(AiidaDeprecationWarning, match=CHDIR_WARNING):
                 transport.chdir(subfolder)
 
             assert subfolder_fullpath == transport.getcwd()