Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scikit-learn dependency #590

Open
Tracked by #392
danielhollas opened this issue Apr 29, 2024 · 0 comments
Open
Tracked by #392

Remove scikit-learn dependency #590

danielhollas opened this issue Apr 29, 2024 · 0 comments
Milestone

Comments

@danielhollas
Copy link
Contributor

danielhollas commented Apr 29, 2024

scikit-learn is only used for PCA to align molecular axes in SmilesWidget. Pulling such a heavy dependency just for this is an overkill. I am not sure if it is even still needed, and I am sure there must be less heavy-weight to do it.

https://stats.stackexchange.com/questions/235882/pca-in-numpy-and-sklearn-produces-different-results

Past PRs for context:
#160
#164

@danielhollas danielhollas mentioned this issue Apr 29, 2024
5 tasks
@danielhollas danielhollas changed the title Remove scikit-learn, only used for PCA to aligh molecular axis. I am not sure if it is needed, and I am sure there must be less heavy-weight to do it. Remove scikit-learn dependency Apr 29, 2024
@danielhollas danielhollas added this to the v0.2.3 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant