You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm working on android app using not simple rive scripts.
Not using java lib because of aichaos/rivescript-java#54.
So running this library in https://github.com/square/duktape-android.
However duktape is complaining about invalid escaping of regexps.
It's about escaped underscore \_ and expected is just _
for example here
(
i'm wondering why is _ escaped if it's not regexp special char, is it something from coffee script or some javascript compatibility/new stuff ?
Probably just me programming extra defensively (and coming from a Perl background, where all sorts of things can be surprise meta characters but escaping things that don't need escaping isn't harmful). The escaping probably isn't necessary at all. 😄
You may send a PR that removes the escaping of underscores in regexps.
I'm working on android app using not simple rive scripts.
Not using java lib because of aichaos/rivescript-java#54.
So running this library in https://github.com/square/duktape-android.
However duktape is complaining about invalid escaping of regexps.
It's about escaped underscore
\_
and expected is just_
for example here
(
rivescript-js/src/parser.coffee
Line 649 in b46d703
i'm wondering why is
_
escaped if it's not regexp special char, is it something from coffee script or some javascript compatibility/new stuff ?The text was updated successfully, but these errors were encountered: