Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding python as a scripting language #56

Open
pmioulet opened this issue Mar 30, 2018 · 6 comments
Open

Adding python as a scripting language #56

pmioulet opened this issue Mar 30, 2018 · 6 comments

Comments

@pmioulet
Copy link
Contributor

pmioulet commented Mar 30, 2018

I was able to add python as a scripting language using jython and a simple handler.

However I needed to modify this commit in order avoid losing indentation in Object handler.

Adding python requires jython as a dependency, not sure if you want to also add this library to the core as a dep, but my first fix gives the possibility of adding it manually if desired.

@marceloverdijk
Copy link
Member

Hi @pmioulet the commit you mentioned is also part of #55 right?

Yes we would be interested in adding Python support. Did you implement it using the JSR-223 scripting engine?

@pmioulet
Copy link
Contributor Author

Yes correct jython supports it so it did not require too much work on my end :)

@marceloverdijk
Copy link
Member

Sounds cool, could you make a PR for that (including a PythonObjectIT similar as e.g. https://github.com/aichaos/rivescript-java/blob/master/rivescript-core/src/integration-test/java/com/rivescript/RubyObjectIT.java

I know I did some experiments with Jython a year ago and faced some problems, but can't remember it exactly anymore I'm afraid.

@marceloverdijk
Copy link
Member

@pmioulet could you please develop the local changes on another branch than master?

@marceloverdijk
Copy link
Member

@pmioulet #55 is merged now. I will wait with a new release for the Python support PR.

@pmioulet
Copy link
Contributor Author

I just pushed one (a year after sorry about that got busy on other stuff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants