Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip id is not sanitized before being put in the data attribute #193

Open
michal-rybinski-91 opened this issue Jul 30, 2022 · 2 comments
Open

Comments

@michal-rybinski-91
Copy link

This leads to errors with query selector:

SyntaxError: Failed to execute 'querySelectorAll' on 'Element': '[data-flipper-id="0.62822"] [data-flip-id="Kontrolle "Nummer falsch" in Hubspot"]' is not a valid selector.
@aholachek
Copy link
Owner

Thanks for making this issue! An easy workaround is to make sure your flip ids are valid data attributes. The next time I update the library I'll add some processing to check for spaces.

@michal-rybinski-91
Copy link
Author

Thank you for replying. Yeah, that's how I have resolved it. There is no build-in browser API for sanitizing string meant to be used in selectors, at least I didn't find it, so I ended up using some snippet from SO
Would be nice for lib to do it, or at least mention in the doc that this id will be used as data attribute and passed to selector "as is".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants