Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return top books by author from Goodreads if author is specified but title is not #3

Closed
ahobsonsayers opened this issue May 1, 2024 · 1 comment
Closed

Return top books by author from Goodreads if author is specified but title is not #3

ahobsonsayers opened this issue May 1, 2024 · 1 comment
Labels
enhancement New feature or request goodreads

Comments

@ahobsonsayers
Copy link
Owner

If the book title is unset in the search but the author is set, it would be good to return the top books by the author (as determined and returned by Goodreads). This could help find book matches.

As AudiobookShelf does not actually allow not specifying a title (unlike author) we can check if the title is empty once we trim spaces. This would allow whitespace to be used as the title to get top books by an author.
@ahobsonsayers ahobsonsayers added enhancement New feature or request goodreads labels May 1, 2024
@ahobsonsayers
Copy link
Owner Author

Completed in release https://github.com/ahobsonsayers/abs-tract/releases/tag/v0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request goodreads
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ahobsonsayers