Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version parsing when patch is missing #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix version parsing when patch is missing #151

wants to merge 1 commit into from

Conversation

jpalaz
Copy link

@jpalaz jpalaz commented Aug 11, 2022

  • update regex to parse version without patch part
  • add version convertion to add fake .0 as patch

@jpalaz
Copy link
Author

jpalaz commented Aug 11, 2022

My attempt to fix #36 issue.
I couldn't run tests but checked my changes just separately and they work.
Also, it's not the fix for 3-dots versions (as 1.2.3.4), only for 1-dot (as 2.0).

@ahmadnassri
Copy link
Owner

thank you, I'll take a look

@nschonni nschonni mentioned this pull request Oct 1, 2022
Open
@ericbuehl
Copy link

@ahmadnassri bump! would love to have this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpalaz @ahmadnassri @ericbuehl