From 342c70312bad7780fd9b4c28b4983d2dc0ccc417 Mon Sep 17 00:00:00 2001 From: John Brittain Date: Mon, 9 Oct 2023 13:12:22 +0100 Subject: [PATCH 1/5] Fix for jax-gpu solver --- pybamm/solvers/jax_solver.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pybamm/solvers/jax_solver.py b/pybamm/solvers/jax_solver.py index 8e7b1b5cc5..beeb932597 100644 --- a/pybamm/solvers/jax_solver.py +++ b/pybamm/solvers/jax_solver.py @@ -215,7 +215,7 @@ def _integrate(self, model, t_eval, inputs=None): y = [] platform = jax.lib.xla_bridge.get_backend().platform.casefold() - if platform.startswith("cpu"): + if len(inputs) <= 1 or platform.startswith("cpu"): # cpu execution runs faster when multithreaded async def solve_model_for_inputs(): async def solve_model_async(inputs_v): From 9748a1b9957ef955839e7517785881b97ca3a3c2 Mon Sep 17 00:00:00 2001 From: John Brittain Date: Mon, 9 Oct 2023 16:36:01 +0100 Subject: [PATCH 2/5] Add changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 421d3bfa29..17a54d41a8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ ## Bug fixes +- Fixed a bug where the JaxSolver would fails when using GPU support with no input parameters ([#3423](https://github.com/pybamm-team/PyBaMM/pull/3423)) - Fixed a bug where empty lists passed to QuickPlot resulted in an IndexError and did not return a meaningful error message ([#3359](https://github.com/pybamm-team/PyBaMM/pull/3359)) - Fixed a bug where there was a missing thermal conductivity in the thermal pouch cell models ([#3330](https://github.com/pybamm-team/PyBaMM/pull/3330)) - Fixed a bug that caused incorrect results of “{Domain} electrode thickness change [m]” due to the absence of dimension for the variable `electrode_thickness_change`([#3329](https://github.com/pybamm-team/PyBaMM/pull/3329)). From 1bca02ac2bcd9d2692ea789d8fef43ef09803e87 Mon Sep 17 00:00:00 2001 From: John Brittain Date: Wed, 25 Oct 2023 10:12:18 +0100 Subject: [PATCH 3/5] Amend changelog --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4d2034e945..42e1d90f91 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ # [Unreleased](https://github.com/pybamm-team/PyBaMM/) +- Fixed a bug where the JaxSolver would fails when using GPU support with no input parameters ([#3423](https://github.com/pybamm-team/PyBaMM/pull/3423)) + # [v23.9rc0](https://github.com/pybamm-team/PyBaMM/tree/v23.9rc0) - 2023-10-31 ## Features @@ -19,7 +21,6 @@ ## Bug fixes -- Fixed a bug where the JaxSolver would fails when using GPU support with no input parameters ([#3423](https://github.com/pybamm-team/PyBaMM/pull/3423)) - Fixed a bug where empty lists passed to QuickPlot resulted in an IndexError and did not return a meaningful error message ([#3359](https://github.com/pybamm-team/PyBaMM/pull/3359)) - Fixed a bug where there was a missing thermal conductivity in the thermal pouch cell models ([#3330](https://github.com/pybamm-team/PyBaMM/pull/3330)) - Fixed a bug that caused incorrect results of “{Domain} electrode thickness change [m]” due to the absence of dimension for the variable `electrode_thickness_change`([#3329](https://github.com/pybamm-team/PyBaMM/pull/3329)). From 09e8cc3a65215d04fc416c1cfd578b4c845e7226 Mon Sep 17 00:00:00 2001 From: John Brittain Date: Wed, 25 Oct 2023 14:51:47 +0100 Subject: [PATCH 4/5] Disable MyST navigation by keys --- docs/conf.py | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/conf.py b/docs/conf.py index 74d1f76488..49e5cf3dc9 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -154,6 +154,7 @@ "navbar_end": ["theme-switcher", "navbar-icon-links"], # add Algolia to the persistent navbar, this removes the default search icon "navbar_persistent": "algolia-searchbox", + "navigation_with_keys": False, "use_edit_page_button": True, "analytics": { "plausible_analytics_domain": "docs.pybamm.org", From 6cc394076b4d63f19235f1c0c5471bb5b2837599 Mon Sep 17 00:00:00 2001 From: jsbrittain <98161205+jsbrittain@users.noreply.github.com> Date: Fri, 27 Oct 2023 10:20:04 +0100 Subject: [PATCH 5/5] Update CHANGELOG.md Co-authored-by: Saransh Chopra --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 42e1d90f91..b02df8ed4c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ # [Unreleased](https://github.com/pybamm-team/PyBaMM/) +## Bug fixes + - Fixed a bug where the JaxSolver would fails when using GPU support with no input parameters ([#3423](https://github.com/pybamm-team/PyBaMM/pull/3423)) # [v23.9rc0](https://github.com/pybamm-team/PyBaMM/tree/v23.9rc0) - 2023-10-31