Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web updates for Porter issue: Remove Utah Metro Townships from SGID #352 #2869

Merged
merged 9 commits into from
Oct 22, 2024

Conversation

DenisePeterson
Copy link
Contributor

No description provided.

Updated blog post removing references to metro townships.
For porter issue: Remove Utah Metro Townships from SGID #352
Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for gis-utah-gov ready!

Name Link
🔨 Latest commit b7258cb
🔍 Latest deploy log https://app.netlify.com/sites/gis-utah-gov/deploys/6717fc0b542896000893a702
😎 Deploy Preview https://deploy-preview-2869--gis-utah-gov.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 1 from production)
Accessibility: 98 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

request-info bot commented Oct 12, 2024

We would appreciate it if you could provide us with more info about this issue/pr!

Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick scan looks good. Thanks for taking care of this.

I see you updated the blog post for ugrcodes. Are the codes just a spreadsheet or are they a table in the sgid? Is it on your radar to edit that data and any place we've used the codes so everything stays synchronized?

Are we making weekly updates to this data? I assume that change implies no more round up blog posts like we were doing. I would strongly consider with how important this data is to provide more detailed updates than the generic weekly.

When we remove pages we need to add a redirect so existing links go somewhere valid instead of to a 404 page. I suggest using municipalities as the replacement. This is done by adding a record to the _redirects file.

Thanks again for doing this and I'll take a closer look next week.

@DenisePeterson
Copy link
Contributor Author

DenisePeterson commented Oct 20, 2024

I see you updated the blog post for ugrcodes. Are the codes just a spreadsheet or are they a table in the sgid? Is it on your radar to edit that data and any place we've used the codes so everything stays synchronized?

To my knowledge, the codes are just in a spreadsheet and not in a table in the SGID. It is on my edit and maintain the data so that everything stays synchronized. I will plan to take a look next week to see if I can find any additional pages that need to be updated.

Are we making weekly updates to this data? I assume that change implies no more round up blog posts like we were doing. I would strongly consider with how important this data is to provide more detailed updates than the generic weekly.

We are making weekly updates to the municipal boundaries data. We will continue doing quarterly blog posts showing updates that were made during that quarter.

When we remove pages we need to add a redirect so existing links go somewhere valid instead of to a 404 page. I suggest using municipalities as the replacement. This is done by adding a record to the _redirects file.

I have a question about updating the _redirects file so I will reach out to you directly.

Copy link
Contributor

github-actions bot commented Oct 21, 2024

Redirects Validation Output

stdout

All redirects validated successfully

stderr


@steveoh steveoh enabled auto-merge (squash) October 22, 2024 19:21
scripts/utilities.mjs Fixed Show fixed Hide fixed
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@steveoh steveoh merged commit 212bd31 into main Oct 22, 2024
9 checks passed
@steveoh steveoh deleted the municipalities-metro-townships branch October 22, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants