Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy pipeline failing on PRs opened from forks #37

Open
szaboopeeter opened this issue Nov 15, 2022 · 0 comments
Open

Deploy pipeline failing on PRs opened from forks #37

szaboopeeter opened this issue Nov 15, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@szaboopeeter
Copy link
Member

Bug report

Describe the bug

The deploy pipeline is failing on PRs opened from forks, because it cannot access API key (secrets are not shared with forks).

Is there a way around it? Or alternatively should we remove this workflow from PRs and have it only on main branch? What's the use-case for publishing from PRs?

To Reproduce

  1. Fork this repo
  2. Create a PR with any change
  3. Wait for deploy pipeline results - for example: https://github.com/agoda-com/net-loadbalancing/actions/runs/3443243315/jobs/5745853755

Expected behavior

Pipeline should be green.

Screenshots

Pipeline is red.

@szaboopeeter szaboopeeter added the bug Something isn't working label Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant