Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect and check existence of all notebooks before converting any #1

Closed
kwinkunks opened this issue Nov 16, 2021 · 2 comments
Closed
Labels
enhancement New feature or request

Comments

@kwinkunks
Copy link
Member

Right now, the notebooks and extras are gathered, then the demos, so we don't know in advance how many we're converting and cannot check if any are missing. So you might wait for 20 to process before finding that the last is missing.

Could fix by building a dict of notebooks with their paths, checking all exist, then looping over to convert.

@kwinkunks kwinkunks added the enhancement New feature or request label Nov 16, 2021
@kwinkunks
Copy link
Member Author

Thought: doing this with a dict would also take care of the issue of duplicate notebooks... although those should be flagged, because it might affect where the notebook ends up. E.g. if listed in curriculum and demos, should go to curriculum.

@kwinkunks
Copy link
Member Author

Transferred to kosu agilescientific/kosu#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant