Skip to content

Commit 6ca756f

Browse files
committed
Fix SMP coverage tests for kernel PR 1206
PR Link - FreeRTOS/FreeRTOS-Kernel#1206 Signed-off-by: Gaurav Aggarwal <[email protected]>
1 parent f6672f9 commit 6ca756f

File tree

1 file changed

+8
-25
lines changed

1 file changed

+8
-25
lines changed

FreeRTOS/Test/CMock/smp/multiple_priorities_no_timeslice/covg_multiple_priorities_no_timeslice_utest.c

Lines changed: 8 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1741,11 +1741,7 @@ void test_coverage_xTaskRemoveFromEventList_remove_eq_priority_task( void )
17411741
uxCurrentNumberOfTasks = uxCurrentNumberOfTasks + 1;
17421742

17431743
/* Expectations. */
1744-
vFakePortGetCoreID_StubWithCallback( NULL );
1745-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Get portGET_CRITICAL_NESTING_COUNT. */
1746-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Get prvYieldCore. */
1747-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Get portGET_CRITICAL_NESTING_COUNT. */
1748-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Get xYieldPendings. */
1744+
vFakePortGetCoreID_ExpectAndReturn( 0 );
17491745
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* portTASK_SWITCH_HOOK(). */
17501746

17511747
/* API call. */
@@ -1942,9 +1938,7 @@ void test_coverage_vTaskRemoveFromUnorderedEventList_remove_higher_priority_task
19421938
uxCurrentNumberOfTasks = uxCurrentNumberOfTasks + 1;
19431939

19441940
/* Expectations. */
1945-
vFakePortGetCoreID_StubWithCallback( NULL );
1946-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Get portGET_CRITICAL_NESTING_COUNT. */
1947-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Get prvYieldCore. */
1941+
vFakePortGetCoreID_ExpectAndReturn( 0 );
19481942

19491943
/* API call. */
19501944
vTaskRemoveFromUnorderedEventList( &xTaskTCB.xEventListItem, 500 | 0x80000000UL );
@@ -1990,9 +1984,7 @@ void test_coverage_vTaskEnterCritical_task_in_critical_already( void )
19901984

19911985
/* Expectations. */
19921986
vFakePortDisableInterrupts_ExpectAndReturn( 0 );
1993-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Get both locks. */
1994-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Increment the critical nesting count. */
1995-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Check first time enter critical section. */
1987+
vFakePortGetCoreID_ExpectAndReturn( 0 );
19961988

19971989
/* API call. */
19981990
vTaskEnterCritical();
@@ -2030,9 +2022,8 @@ void test_coverage_vTaskEnterCriticalFromISR_isr_in_critical_already( void )
20302022
vFakePortGetCoreID_StubWithCallback( NULL );
20312023

20322024
/* Expectations. */
2025+
vFakePortGetCoreID_ExpectAndReturn( 0 );
20332026
ulFakePortSetInterruptMaskFromISR_ExpectAndReturn( 0x5a5a ); /* The value to be verified. */
2034-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Get ISR locks. */
2035-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Increment the critical nesting count. */
20362027

20372028
/* API call. */
20382029
xSavedInterruptStatus = vTaskEnterCriticalFromISR();
@@ -2073,10 +2064,7 @@ void test_coverage_vTaskExitCritical_task_enter_critical_mt_1( void )
20732064
vFakePortGetCoreID_StubWithCallback( NULL );
20742065

20752066
/* Expectations. */
2076-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* configASSERT. */
2077-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Check critical nesting count. */
2078-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Decrease the critical nesting count. */
2079-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Check exit critical section. */
2067+
vFakePortGetCoreID_ExpectAndReturn( 0 );
20802068

20812069
/* API call. */
20822070
vTaskExitCritical();
@@ -2114,8 +2102,7 @@ void test_coverage_vTaskExitCritical_task_not_in_critical( void )
21142102
vFakePortGetCoreID_StubWithCallback( NULL );
21152103

21162104
/* Expectations. */
2117-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* configASSERT. */
2118-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Check critical nesting count. */
2105+
vFakePortGetCoreID_ExpectAndReturn( 0 );
21192106

21202107
/* API call. */
21212108
vTaskExitCritical();
@@ -2172,10 +2159,7 @@ void test_coverage_vTaskExitCriticalFromISR_isr_enter_critical_mt_1( void )
21722159
vFakePortGetCoreID_StubWithCallback( NULL );
21732160

21742161
/* Expectations. */
2175-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* configASSERT. */
2176-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Check critical nesting count. */
2177-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Decrement critical nesting count. */
2178-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Check critical nesting count. */
2162+
vFakePortGetCoreID_ExpectAndReturn( 0 );
21792163

21802164
/* API call. */
21812165
/* The mask value has not effect since ISR enters critical section more than 1 time. */
@@ -2215,8 +2199,7 @@ void test_coverage_vTaskExitCriticalFromISR_isr_not_in_critical( void )
22152199
vFakePortGetCoreID_StubWithCallback( NULL );
22162200

22172201
/* Expectations. */
2218-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* configASSERT. */
2219-
vFakePortGetCoreID_ExpectAndReturn( 0 ); /* Check critical nesting count. */
2202+
vFakePortGetCoreID_ExpectAndReturn( 0 );
22202203

22212204
/* API call. */
22222205
/* The mask value has not effect since ISR is not in critical section. */

0 commit comments

Comments
 (0)