fix(payment): address github-code-quality bot review on PR #53

- Wrap the warn-once flag in a _WarnedFlags class so the symbol is
  referenced at module scope (was: bare module-level bool only mutated
  via `global`, which the lint pass flagged as unused at module scope).
- Drop the per-test `import compose_rails as mod` indirection; reset
  via _WarnedFlags directly. Eliminates the mixed `import` / `from
  import` styles bot complaint on test_compose_rails.py.

No behavior change.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: vvillait88

agentscore_commerce/payment/compose_rails.py

@@ -20,10 +20,19 @@
 from agentscore_commerce.payment.usdc import USDC
 
 _SOLANA_MAINNET_CAIP2 = "solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp"
-_warned_stripe_below_minimum = False
 _logger = logging.getLogger(__name__)
 
 
+class _WarnedFlags:
+    """Warn-once flags for helpers that shouldn't spam logs.
+
+    Wrapped in a class instead of a bare module-level bool so the symbol is
+    referenced at module scope rather than mutated only via ``global``.
+    """
+
+    stripe_below_minimum: bool = False
+
+
 def build_mppx_compose_rails(
     *,
     amount_usd: str,
@@ -104,9 +113,8 @@ def build_mppx_compose_rails(
         except (InvalidOperation, TypeError, ValueError):
             amount_decimal = None
         if amount_decimal is not None and amount_decimal < STRIPE_MIN_CHARGE_USD:
-            global _warned_stripe_below_minimum
-            if not _warned_stripe_below_minimum:
-                _warned_stripe_below_minimum = True
+            if not _WarnedFlags.stripe_below_minimum:
+                _WarnedFlags.stripe_below_minimum = True
                 _logger.warning(
                     "[build_mppx_compose_rails] Dropping stripe/charge rail: amount_usd=%s is below "
                     "Stripe's $%s USD minimum. Stripe's fixed ~$0.30 fee makes sub-50-cent charges "

tests/test_compose_rails.py

@@ -2,7 +2,7 @@
 
 import pytest
 
-from agentscore_commerce.payment.compose_rails import build_mppx_compose_rails
+from agentscore_commerce.payment.compose_rails import _WarnedFlags, build_mppx_compose_rails
 
 
 def test_emits_single_tempo_intent_when_only_tempo_recipient() -> None:
@@ -57,9 +57,7 @@ def test_raises_when_amount_unparseable_with_solana_rail() -> None:
 
 
 def test_auto_drops_stripe_when_amount_below_min(caplog: pytest.LogCaptureFixture) -> None:
-    import agentscore_commerce.payment.compose_rails as mod
-
-    mod._warned_stripe_below_minimum = False  # reset module-level warn-once flag
+    _WarnedFlags.stripe_below_minimum = False  # reset module-level warn-once flag
     with caplog.at_level("WARNING"):
         rails = build_mppx_compose_rails(amount_usd="0.01", tempo_recipient="0xabc")
     assert all(r[0] != "stripe/charge" for r in rails)