Update to agent-client-protocol-schema v0.8.0 (#17)

Author: benbrandt

Cargo.lock

@@ -27,7 +27,7 @@ tokio = { version = "1.48", features = ["full"] }
 tokio-util = { version = "0.7", features = ["compat"] }
 
 # Protocol
-agent-client-protocol-schema = "0.7.0"
+agent-client-protocol-schema = { version = "0.8.0" }
 
 # Serialization
 serde = { version = "1.0", features = ["derive", "rc"] }

Cargo.toml

@@ -32,7 +32,7 @@ impl Agent for MyAgent {
 
     async fn new_session(&self, _args: NewSessionRequest) -> Result<NewSessionResponse> {
         eprintln!("[{}] Creating session", self.name);
-        Ok(NewSessionResponse::new("session-1".into()))
+        Ok(NewSessionResponse::new("session-1"))
     }
 
     async fn prompt(&self, _args: PromptRequest) -> Result<PromptResponse> {

examples/migration/agent_legacy.rs

@@ -25,7 +25,7 @@ async fn main() -> Result<(), sacp::Error> {
         // ANCHOR: handler_new_session
         .on_receive_request(async move |_req: NewSessionRequest, cx| {
             eprintln!("[{}] Creating session", agent_name);
-            cx.respond(NewSessionResponse::new("session-1".into()))
+            cx.respond(NewSessionResponse::new("session-1"))
         })
         // ANCHOR_END: handler_new_session
         // ANCHOR: handler_prompt

examples/migration/agent_sacp.rs

@@ -18,7 +18,7 @@ async fn main() -> Result<(), sacp::Error> {
             cx.respond(InitializeResponse::new(req.protocol_version))
         })
         .on_receive_request(async move |_req: NewSessionRequest, cx| {
-            cx.respond(NewSessionResponse::new("session-1".into()))
+            cx.respond(NewSessionResponse::new("session-1"))
         })
         // ANCHOR: blocking_risk
         .on_receive_request(async move |_req: PromptRequest, cx| {

examples/migration/agent_with_callbacks_sacp.rs

@@ -5,10 +5,10 @@
 use agent_client_protocol::{
     Agent, Client, ClientSideConnection, CreateTerminalRequest, CreateTerminalResponse, Error,
     ExtNotification, ExtRequest, ExtResponse, InitializeRequest, KillTerminalCommandRequest,
-    KillTerminalCommandResponse, NewSessionRequest, PromptRequest, ReadTextFileRequest,
-    ReadTextFileResponse, ReleaseTerminalRequest, ReleaseTerminalResponse,
+    KillTerminalCommandResponse, NewSessionRequest, PromptRequest, ProtocolVersion,
+    ReadTextFileRequest, ReadTextFileResponse, ReleaseTerminalRequest, ReleaseTerminalResponse,
     RequestPermissionRequest, RequestPermissionResponse, Result, SessionNotification,
-    TerminalOutputRequest, TerminalOutputResponse, V1, WaitForTerminalExitRequest,
+    TerminalOutputRequest, TerminalOutputResponse, WaitForTerminalExitRequest,
     WaitForTerminalExitResponse, WriteTextFileRequest, WriteTextFileResponse,
 };
 use futures::FutureExt;
@@ -125,7 +125,9 @@ async fn main() -> Result<()> {
             // Now we can send requests using the connection
             // ANCHOR: send_requests
             // Initialize the agent
-            let init_response = connection.initialize(InitializeRequest::new(V1)).await?;
+            let init_response = connection
+                .initialize(InitializeRequest::new(ProtocolVersion::LATEST))
+                .await?;
 
             eprintln!("Agent initialized: {:?}", init_response.agent_info);
 

examples/migration/client_legacy.rs

@@ -2,10 +2,11 @@
 //!
 //! This example shows how to connect to an agent and send requests using the handler chain API.
 
+use agent_client_protocol::ProtocolVersion;
 use sacp::JrHandlerChain;
 use sacp::schema::{
     InitializeRequest, NewSessionRequest, PromptRequest, ReadTextFileRequest,
-    RequestPermissionRequest, SessionNotification, VERSION, WriteTextFileRequest,
+    RequestPermissionRequest, SessionNotification, WriteTextFileRequest,
 };
 use tokio_util::compat::{TokioAsyncReadCompatExt, TokioAsyncWriteCompatExt};
 
@@ -48,7 +49,7 @@ async fn main() -> Result<(), sacp::Error> {
                 // ANCHOR: send_requests
                 // Initialize the agent
                 let init_response = cx
-                    .send_request(InitializeRequest::new(VERSION))
+                    .send_request(InitializeRequest::new(ProtocolVersion::LATEST))
                     .block_task()
                     .await?;
 

examples/migration/client_sacp.rs

@@ -133,7 +133,7 @@ pub trait Agent {
     ///
     /// See protocol docs: [Extensibility](https://agentclientprotocol.com/protocol/extensibility)
     async fn ext_method(&self, _args: ExtRequest) -> Result<ExtResponse> {
-        Ok(RawValue::NULL.to_owned().into())
+        Ok(ExtResponse::new(RawValue::NULL.to_owned().into()))
     }
 
     /// Handles extension notifications from the client.

src/agent-client-protocol/src/agent.rs

@@ -155,7 +155,7 @@ pub trait Client {
     ///
     /// See protocol docs: [Extensibility](https://agentclientprotocol.com/protocol/extensibility)
     async fn ext_method(&self, _args: ExtRequest) -> Result<ExtResponse> {
-        Ok(RawValue::NULL.to_owned().into())
+        Ok(ExtResponse::new(RawValue::NULL.to_owned().into()))
     }
 
     /// Handles extension notifications from the agent.

src/agent-client-protocol/src/client.rs

@@ -222,7 +222,7 @@ impl Side for ClientSide {
                 if let Some(custom_method) = method.strip_prefix('_') {
                     Ok(AgentRequest::ExtMethodRequest(ExtRequest::new(
                         custom_method,
-                        params.to_owned(),
+                        params.to_owned().into(),
                     )))
                 } else {
                     Err(Error::method_not_found())
@@ -242,7 +242,7 @@ impl Side for ClientSide {
                 if let Some(custom_method) = method.strip_prefix('_') {
                     Ok(AgentNotification::ExtNotification(ExtNotification::new(
                         custom_method,
-                        RawValue::from_string(params.get().to_string())?,
+                        RawValue::from_string(params.get().to_string())?.into(),
                     )))
                 } else {
                     Err(Error::method_not_found())
@@ -525,7 +525,7 @@ impl Side for AgentSide {
                 if let Some(custom_method) = method.strip_prefix('_') {
                     Ok(ClientRequest::ExtMethodRequest(ExtRequest::new(
                         custom_method,
-                        params.to_owned(),
+                        params.to_owned().into(),
                     )))
                 } else {
                     Err(Error::method_not_found())
@@ -545,7 +545,7 @@ impl Side for AgentSide {
                 if let Some(custom_method) = method.strip_prefix('_') {
                     Ok(ClientNotification::ExtNotification(ExtNotification::new(
                         custom_method,
-                        RawValue::from_string(params.get().to_string())?,
+                        RawValue::from_string(params.get().to_string())?.into(),
                     )))
                 } else {
                     Err(Error::method_not_found())