[ cleanup ] follow the shellcheck advice

Author: gallais

stdlib-install.sh

@@ -6,35 +6,27 @@
 set -eu
 
 isDebugMode() {
-  ! [ -z ${DEBUG-} ]
+  [ -n "${DEBUG-}" ]
 }
 
-if ! [ -z ${SHELL_DEBUG-} ]; then
+if [ -n "${SHELL_DEBUG-}" ]; then
   set -x
 fi
 
 throwError() {
-  echo "\033[91m✗\033[0m $1." >&2
+  printf "\033[91m✗\033[0m %s.\n" "$1" >&2
   exit 1
 }
 
-logHappy() {
-  echo "\033[32m✔\033[0m $1"
-}
-
-logUnhappy() {
-  echo "\033[91m✗\033[0m $1."
-}
-
-logWarning() {
-  echo "\033[93m⚠\033[0m $1"
-}
+logHappy()   { printf "\033[32m✔\033[0m %s.\n" "$1"; }
+logUnhappy() { printf "\033[91m✗\033[0m %s.\n" "$1"; }
+logWarning() { printf "\033[93m⚠\033[0m %s.\n" "$1"; }
 
 ########################################################################
 ## PRELIMINARY CHECKS
 
 checkDependency () {
-  if ! [ -x "$(command -v $1)" ]; then
+  if ! [ -x "$(command -v "$1")" ]; then
     throwError "Missing dependency: I could not find the executable '$1'"
   elif isDebugMode; then
     logHappy "Found '$1'"
@@ -54,28 +46,29 @@ checkDependency "wget"
 
 # Pick the Agda executable to analyse
 # unless the caller has specified one
-if [ -z ${AGDA_EXEC-} ]; then
+if [ -z "${AGDA_EXEC-}" ]; then
   while true; do
-    read -p "What's the name of your Agda executable (default: agda)? " AGDA_EXEC
+    printf "What's the name of your Agda executable (default: agda)? "
+    read -r AGDA_EXEC
     if [ -z "$AGDA_EXEC" ]; then
       AGDA_EXEC=agda
     fi
     # Double check that the command exists
-    if ! [ -x "$(command -v $AGDA_EXEC)" ]; then
+    if ! [ -x "$(command -v "$AGDA_EXEC")" ]; then
       logUnhappy "'$AGDA_EXEC' is not a valid executable"
     else
       break
     fi
   done
-elif ! [ -x "$(command -v $AGDA_EXEC)" ]; then
+elif ! [ -x "$(command -v "$AGDA_EXEC")" ]; then
   throwError "'$AGDA_EXEC' is not a valid executable"
 fi
 
 logHappy "Agda executable: $AGDA_EXEC"
 
 # Ask the executable for its version number
 # unless the caller has specified one
-if [ -z ${AGDA_VERSION-} ]; then
+if [ -z "${AGDA_VERSION-}" ]; then
   # There is a more recent "--numeric-version" option but old
   # versions of Agda do not implement it!
   AGDA_VERSION=$($AGDA_EXEC --version | head -n 1 | sed "s/^[a-zA-Z ]*\(2[0-9.]*\)\(-.*\)*$/\1/")
@@ -90,27 +83,27 @@ logHappy "Agda version number: $AGDA_VERSION"
 
 # Pick the install directory
 # unless the caller has specified one
-if [ -z ${AGDA_DIR-} ]; then
+if [ -z "${AGDA_DIR-}" ]; then
   AGDA_DIR=$($AGDA_EXEC --print-agda-app-dir | head -n 1 || true)
   if echo "$AGDA_DIR" | grep -Eq "^Error.*$"; then
     AGDA_DIR="$HOME/.agda"
   fi
-  read -p "Where do you want to install the library (default: $AGDA_DIR)? " AGDA_DIR_OVERWRITE
-  if ! [ -z "$AGDA_DIR_OVERWRITE" ]; then
+  printf "Where do you want to install the library (default: %s)? " "$AGDA_DIR"
+  read -r AGDA_DIR_OVERWRITE
+  if [ -n "$AGDA_DIR_OVERWRITE" ]; then
     AGDA_DIR="$AGDA_DIR_OVERWRITE"
   fi
 fi
 
 logHappy "Agda directory: $AGDA_DIR"
 
-if [ -z ${STDLIB_VERSION-} ]; then
+if [ -z "${STDLIB_VERSION-}" ]; then
   case "$AGDA_VERSION" in
     "2.8.0")   STDLIB_VERSION="2.3" ;;
     "2.7.0.1") STDLIB_VERSION="2.3" ;;
     "2.7.0")   STDLIB_VERSION="2.2" ;;
     "2.6.4.3") STDLIB_VERSION="2.1" ;;
     "2.6.4.2") STDLIB_VERSION="2.0" ;;
-    "2.6.4.2") STDLIB_VERSION="2.0" ;;
     "2.6.4.1") STDLIB_VERSION="2.0" ;;
     "2.6.4")   STDLIB_VERSION="2.0" ;;
     "2.6.3")   STDLIB_VERSION="1.7.3" ;;
@@ -145,7 +138,8 @@ logHappy "Successfully downloaded the standard library"
 if [ -d "$STDLIB_DIR_NAME" ]; then
   logWarning "The directory $AGDA_DIR/$STDLIB_DIR_NAME already exists."
   while true; do
-    read -p "Do you want to overwrite it? (yN) " DIR_OVERWRITE
+    printf "Do you want to overwrite it? (yN) "
+    read -r DIR_OVERWRITE
     DIR_OVERWRITE=${DIR_OVERWRITE:-n}
     case "$DIR_OVERWRITE" in
       [yY]*) DIR_OVERWRITE="y"; break;;