Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument byte v string typing when generating weblogo in scons #50

Open
aflaus opened this issue Apr 13, 2020 · 1 comment
Open

Argument byte v string typing when generating weblogo in scons #50

aflaus opened this issue Apr 13, 2020 · 1 comment
Assignees

Comments

@aflaus
Copy link
Member

aflaus commented Apr 13, 2020

Error when running SConstruct after successful dependencies check in Ubuntu 20.04 beta.

scons: *** [figs/seqlogo_H2A_cds.pdf] TypeError : starts with first arg must be bytes or a tuple of bytes, not str

This is presumably because an input file is being opened as binary by default in python3. Not sure where problem is in code but should be easy to set the type correctly.
https://stackoverflow.com/questions/19827615/startswith-typeerror-in-function/

@aflaus
Copy link
Member Author

aflaus commented Apr 13, 2020

OK, I solved this. On line 144 of init.py it is necessary to add the option "text=True" to subprocess.check_output.

However, this probably creates a dependency for python 3.7 or greater
https://docs.python.org/3/library/subprocess.html#using-the-subprocess-module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants