Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] SSL on Web Server #94

Closed
smarthome-enthusiast opened this issue Apr 2, 2024 · 2 comments
Closed

[Feature] SSL on Web Server #94

smarthome-enthusiast opened this issue Apr 2, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@smarthome-enthusiast
Copy link

Is your feature request related to a problem? Please describe.
I'm trying to have Checkrr displayed on HomeAssistant through an iFrame but I'm unable to load HTTP inside a HTTPS web server.

Describe the solution you'd like
Would it be possible to support SSL? Maybe through the config under the webserver options, we could specify the certificate and key and enable SSL on the same port. i.e port 8585 is either served as HTTP or HTTPS.

Describe alternatives you've considered
Disabling HTTPS on HomeAssistant but that would make it very insecure during external access.

@smarthome-enthusiast smarthome-enthusiast added the enhancement New feature or request label Apr 2, 2024
@aetaric aetaric added the good first issue Good for newcomers label Apr 2, 2024
@aetaric aetaric added this to the 3.4.0 milestone Apr 12, 2024
aetaric pushed a commit that referenced this issue Sep 30, 2024
@aetaric
Copy link
Owner

aetaric commented Sep 30, 2024

hey @smarthome-enthusiast This was just added in d5532b1. If possible, could you test a local build of checkrr from main? Just want to make sure it's working for your usecase prior to 3.4.0's release.

@aetaric
Copy link
Owner

aetaric commented Oct 8, 2024

confirmed working with a self-signed cert. Closing as completed.
Screenshot 2024-10-08 at 11 02 03
Screenshot 2024-10-08 at 11 03 09

@aetaric aetaric closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants