Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RV convolutions #25

Open
ricardoV94 opened this issue Jul 4, 2021 · 2 comments
Open

Implement RV convolutions #25

ricardoV94 opened this issue Jul 4, 2021 · 2 comments
Labels
enhancement New feature or request request discussion

Comments

@ricardoV94
Copy link
Contributor

ricardoV94 commented Jul 4, 2021

We could try to wrap some method from scipy.integrate and use it to convolve continuous variables in a joint graph of z = x + y where neither variable {x, y} is being conditioned on.

I don't know how feasible this would be, since scipy requires a callable. Can we use something like OpFromGraph?

Obviously we can (and should) implement the optimized graphs for variables that have simple analytical form such as the convolution of two gaussians (which I think pymc-symbolic could already do)?

@brandonwillard
Copy link
Member

Are you talking about creating a numerical integration Op? We could definitely do that, but that approach falls well outside of the symbolic stuff we're doing here. Plus, that approach has severe limitations (e.g. the kind that often lead one to MCMC), so it's difficult to imagine such a thing being applied automatically.

We could reproduce some simple symbolic convolutions and build on those over time. There's a lot that can be done with only Laplace and Mellin transforms in the area of probability theory, so we wouldn't really need to implement symbolic integration in its more general forms.

@rlouf
Copy link
Member

rlouf commented Nov 17, 2022

We should start with reasoning at the level of random variables. We can already implement relations for convolutions of known distributions that result in a known distribution in AeMCMC, see aesara-devs/aemcmc#57.

Efforts in this direction should be pursued following the same approach.

@rlouf rlouf closed this as completed Nov 17, 2022
@rlouf rlouf reopened this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request request discussion
Projects
None yet
Development

No branches or pull requests

3 participants