Recognize reserved words in variable and constant declaration #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there was a variable declaration that was not followed by a type annotation and the next lined started a function declaration, the function declaration was not recognized. Fixed by including reserved-word-pop before matching the variable identifier.
|
Maybe the identifier match in Then |
|
I've updated the pull request with a new commit that uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there was a variable declaration that was not followed by a type annotation and the next line started a function declaration, the function declaration was not recognized.
Fixed by including reserved-word-pop before matching the variable identifier.
Resolves #4
I hope this doesn't introduce new problems, but I visually checked it against the included test files and against my own code base and couldn't find a problem.