feat(update): introduce "path" variable #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In protobuf, the resource path is only an input parameter in the context of update. This has resulted in increased complexity, such as the introduction of an `IDENTIFIER` field behavior that must be special-cased by linters and generators. Normalizing update to the same pattern fixes this issue. related to aep-dev#181
gibson042
reviewed
Aug 21, 2024
Co-authored-by: Richard Gibson <[email protected]>
toumorokoshi
added a commit
to aep-dev/aepc
that referenced
this pull request
Aug 23, 2024
To ensure full adherence with the AEPs, fix all AEP-linter errors. This resolves almost all AEP-linter errors, sans a change to introduce a path variable for Update which is being discussed in aep-dev/aeps#210. One other error remains, which has to be do with the existence of an APPLY method here: aep-dev/aeps#110. Proto package generation also now aligns with AEP best practices, and to enable flexibility is now decoupled from the API name.
rambleraptor
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In protobuf, the resource path is only an input parameter in the context of update. This has resulted in increased complexity, such as the introduction of an
IDENTIFIERfield behavior that must be special-cased by linters and generators.Normalizing update to the same pattern fixes this issue.
related to #181
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(usually
prettier -w .)