-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for external-dns #1
Comments
Interesting idea, didn't thought of that. I may give it a try, their provider implementation doesn't look like a big deal. |
Some notes about progress: ATM i'm trying to implement the external-dns provider interface. There is an obstacle to some content that netcup DNS API doesn't provide lookup on zones records being used -- because of this restriction, i decided that the domain filter parameter will always be mandatory (as a hint to the system which domains can be used). |
Thx. Guess the named restrictions wont be a problem for me |
@aellwein are you still working on this? This would be a great addition :) |
@mrueg sorry for the delay, i've been busy lately. |
@aellwein Happy to collaborate on that if you'd like. |
@aellwein fyi I think I made some progress on the ApplyChanges and used your code (hope you don't mind) in https://github.com/mrueg/external-dns/tree/add-netcup-provider |
@mrueg great, i'm happy you made the progress and took the effort! I don't mind you used my previous work. |
Thanks! I've also rebased on your latest commit to preserve attribution. Hope to give it a test in the next couple of days. Merry christmas! Edit: I've added some unit tests as well. |
@mrueg i took a quick look to your branch. I have no strong opinion whether the new flag is reasonable here, so it's okay with me. I still need to test it in my own cluster to see how it behaves. |
Thanks for the feedback! I've removed the comment. I think the domainFilter has different semantics (e.g. you can't provide a regex to netcup's API to get the zones), so I've added a zones field. I've added a tutorial here: https://github.com/kubernetes-sigs/external-dns/blob/20c217a1cabf95868025a8bf843149ce2ef9e336/docs/tutorials/netcup.md |
@aellwein I've tested it locally and it seems to work fine. I would be able to raise a PR and wanted to check in if you're okay with being listed as a maintainer as well? |
@mrueg 👍🏻 sure thing, count me in. |
Add support for https://www.netcup-wiki.de/wiki/CCP_API via netcup-dns-api library. See also: aellwein/netcup-dns-api#1 Co-Authored-By: Alex Ellwein <[email protected]>
Add support for https://www.netcup-wiki.de/wiki/CCP_API via netcup-dns-api library. See also: aellwein/netcup-dns-api#1 Co-Authored-By: Alex Ellwein <[email protected]>
Add support for https://www.netcup-wiki.de/wiki/CCP_API via netcup-dns-api library. See also: aellwein/netcup-dns-api#1 Co-Authored-By: Alex Ellwein <[email protected]>
Add support for https://www.netcup-wiki.de/wiki/CCP_API via netcup-dns-api library. See also: aellwein/netcup-dns-api#1 Co-Authored-By: Alex Ellwein <[email protected]>
Add support for https://www.netcup-wiki.de/wiki/CCP_API via netcup-dns-api library. See also: aellwein/netcup-dns-api#1 Co-Authored-By: Alex Ellwein <[email protected]>
Add support for https://www.netcup-wiki.de/wiki/CCP_API via netcup-dns-api library. See also: aellwein/netcup-dns-api#1 Co-Authored-By: Alex Ellwein <[email protected]>
Add support for https://www.netcup-wiki.de/wiki/CCP_API via netcup-dns-api library. See also: aellwein/netcup-dns-api#1 Co-Authored-By: Alex Ellwein <[email protected]>
With webhook being available in external-dns, I've moved development over here into the webhook plugin: https://github.com/mrueg/external-dns-netcup-webhook (still WIP) |
@mrueg looks good, seems that external-dns folks go the same direction with webhooks as the cert-manager... |
It would be nice to see also a netcup provider in kubernetes-external-dns . I would assume its very similar to your existing webhook implementation
The text was updated successfully, but these errors were encountered: