fixed some bugs

Author: aeldidi

cbuild.py

@@ -263,7 +263,7 @@ def git(*git_argv) -> subprocess.CompletedProcess[bytes]:
         for submod in result.submodules:
             MOD_CACHE[result.import_path + "/" + submod] = result.get_submodule(submod)
         if currentmod == import_path:
-            self.dependencies.add(result)
+            self.dependencies.add(result.import_path)
             # we imported the root module
             return result
 
@@ -276,7 +276,7 @@ def git(*git_argv) -> subprocess.CompletedProcess[bytes]:
             )
 
         result = result.get_submodule(submodname)
-        self.dependencies.add(result)
+        self.dependencies.add(result.import_path)
         return result
 
     @staticmethod
@@ -490,6 +490,14 @@ def build(mod: Module, type: Literal["exe", "lib"]):
         f"--include={mod.h()}",
         # TODO: remove if release flag is present.
         "-fsanitize=address,undefined",
+        "-Wall",
+        "-Wextra",
+        "-Werror=conversion",
+        "-Werror=shadow",
+        "-Wno-sign-conversion",  # so uint - 1 doesn't warn of conversion
+        "-fasynchronous-unwind-tables",  # so _Unwind_* always works.
+        "-Werror=format-security",
+        "-Werror=implicit-function-declaration",
         "-g3",
     ]
     if type == "lib":

modfile/modfile.c

@@ -95,9 +95,9 @@ modfile_parse(Arena* mem, Arena scratch, char* path)
 					&platform_flags,
 					str_format(mem, "%s", parts.data[1]));
 			for (size_t j = 2; j < parts.len; j += 1) {
-				char* tmp = str_format(
+				char* tmp_flag = str_format(
 						mem, "%s", parts.data[j]);
-				*slice_push(mem, flags) = tmp;
+				*slice_push(mem, flags) = tmp_flag;
 			}
 
 			continue;