Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mod operator incorrect for decimals #2169

Open
piotrszul opened this issue Feb 24, 2025 · 1 comment
Open

mod operator incorrect for decimals #2169

piotrszul opened this issue Feb 24, 2025 · 1 comment
Labels
bug Something isn't working fhirpath Related to fhirpath reference implementation
Milestone
v8.0.0

Comments

@piotrszul
Copy link
Collaborator

FHIR R4 Exclusions

Details

Expected: true but got: false ==> expected: <true> but was: <false>

  • 2.2 mod 1.8 = 0.4 [** testMod4]
@piotrszul piotrszul added bug Something isn't working fhirpath Related to fhirpath reference implementation labels Feb 24, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Pathling Feb 24, 2025
@johngrimes
Copy link
Member

We also need to update this line in the documentation:

For Integer and Decimal, +, - and * return the same type as the left operand, / returns Decimal and mod returns Integer.

@johngrimes johngrimes added this to the v8.0.0 milestone Feb 24, 2025
@johngrimes johngrimes moved this from Backlog to Planned in Pathling Feb 24, 2025
@piotrszul piotrszul moved this from Planned to In progress in Pathling Feb 26, 2025
piotrszul added a commit that referenced this issue Feb 26, 2025
@piotrszul
Fixing #2169: Making 'mod' result decimal for decimal arguments.
19c44ca
piotrszul added a commit that referenced this issue Mar 3, 2025
@piotrszul
Fixing #2169: Making 'mod' result decimal for decimal arguments.
78ca5da
@piotrszul piotrszul mentioned this issue Mar 3, 2025
Merged
@piotrszul piotrszul moved this from In progress to Done in Pathling Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fhirpath Related to fhirpath reference implementation
Projects
Pathling
Status: Done
Milestone
v8.0.0
Development

No branches or pull requests
2 participants
@johngrimes @piotrszul