Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception handling in CustomTrackingEvent #8

Open
dimamo5 opened this issue May 28, 2019 · 0 comments
Open

Improve exception handling in CustomTrackingEvent #8

dimamo5 opened this issue May 28, 2019 · 0 comments

Comments

@dimamo5
Copy link
Collaborator

dimamo5 commented May 28, 2019

I know this is not from this PR, but if we don't have a concrete use case, I would prefer not to include the functionality to get a CustomTrackingEvent from JSON. Also, I think the exceptions thrown should be custom (like if a given field cannot be extracted from the input JSON) and are, at this moment, generic JSON exceptions.

Originally posted by @belerophon in #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dimamo5