Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Notification Event for general download #3764

Open
ykelvis opened this issue Dec 31, 2024 · 3 comments
Open

[Enhancement]: Notification Event for general download #3764

ykelvis opened this issue Dec 31, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@ykelvis
Copy link

ykelvis commented Dec 31, 2024

Type of Enhancement

Server Backend

Describe the Feature/Enhancement

There is one notification event for auto-download.

Notification Event: onPodcastEpisodeDownloaded Triggered when a podcast episode is auto-downloaded

This can only be triggered by audiobookshelf's cron update. But a) use the api path /api/podcasts/{id}/checknew to update a podcast or b) download episode using the webui don't seem to trigger this event.

Why would this be helpful?

It would be helpful if any successful download event can trigger notification. I'm using a script to check new episodes, so the situation is like (a). Also in case of (b) if an old podcast/episode is added, it's good to notify user there's new content available.

Future Implementation (Screenshot)

N/A

Audiobookshelf Server Version

v2.17.6

Current Implementation (Screenshot)

No response

@ykelvis ykelvis added the enhancement New feature or request label Dec 31, 2024
@nichwall
Copy link
Contributor

Would this be a single notification that new episodes were downloaded or a notification for each episode as it is downloaded?

Like if you are downloading new episodes in the web UI, and then decide you want to download more episodes, should there be a timeout before a new notification is sent (like 5 minutes), or would we want to send the notification every time the download queue is empty?

@ykelvis
Copy link
Author

ykelvis commented Jan 1, 2025

It's a download completion event so I don't think audiobookshelf should process anything, fire a notification for every single episode sounds good.

@advplyr
Copy link
Owner

advplyr commented Jan 1, 2025

If downloading a thousand episodes at a time it could trigger a thousand notifications. I brought up the same issue with adding a notification for every new library item #3464 (comment).

That could be an issue we just pass to the user to handle. If we do that there will most likely be follow on issues opened with users triggering a thousand notifications and requesting additional support for throttling or batch notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants