Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black bands on videos cards #20

Closed
adrienpoly opened this issue Jun 21, 2023 · 2 comments
Closed

Black bands on videos cards #20

adrienpoly opened this issue Jun 21, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@adrienpoly
Copy link
Owner

The Youtube thumbnails have black bands on the top/bottom of the image.
Those bands should be hidden by the CSS

Looking at #19 I could spot the card sometime will show the black bands (sometimes not!!!).

I think it is mostly occurring on Safari

CleanShot 2023-06-21 at 09 14 19@2x
@adrienpoly adrienpoly added the bug Something isn't working label Jun 21, 2023
@adrienpoly adrienpoly added the help wanted Extra attention is needed label Aug 5, 2023
@adrienpoly
Copy link
Owner Author

This must be a tricky CSS thing for Safari. I quickly searched for a solution but could not find anything obvious. would love help on that one

Oli0li added a commit to Oli0li/rubyvideo that referenced this issue Sep 13, 2023
@Oli0li
Hide black bands on video thumbnails
a5572a4 
This is in order to fix an issue present on Safari.
adrienpoly#20
@Oli0li Oli0li mentioned this issue Sep 13, 2023
Merged
@Oli0li
Copy link
Contributor

Oli0li commented Sep 13, 2023

Hello @adrienpoly, I just looked into this today and gave it a try with PR #55.

adrienpoly pushed a commit that referenced this issue Sep 13, 2023
@Oli0li
Hide black bands on video thumbnails (#55)
009bc6a 
This is in order to fix an issue present on Safari.
#20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adrienpoly @Oli0li