Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inverse property to "accept" property #6

Open
kvvinokurov opened this issue Oct 29, 2019 · 6 comments
Open

Add inverse property to "accept" property #6

kvvinokurov opened this issue Oct 29, 2019 · 6 comments

Comments

@kvvinokurov
Copy link

This is:

  • Feature request
  • Question

Detailed Description

I allow sending all files, for example, with the exception of executable ones.

@adrians5j
Copy link
Owner

adrians5j commented Nov 3, 2019

Cool @kvvinokurov,

I just can't think of a good name for the prop.

Currently, we have accept for whitelist. What would be the name of the inverse prop (blacklist)?

If we would go in a similar fashion like accept, maybe we could add reject or refuse prop?

I guess:
<Files reject={["application/exe"]}/>

The other ideas that came to my mind: acceptInverse, notAccept, acceptBlacklist.

You have any ideas maybe? :)

P.S. accept would always have higher priority than reject. Meaning if the user sets both (eg. by an accident), accept would be used, and reject would be ignored.

@kvvinokurov
Copy link
Author

May be exclude

@kvvinokurov
Copy link
Author

Maybe add a filter by file name in regex format in addition?

For example, Microsoft SharePoint has the following restrictions on the file name:
Information about the characters that you cannot use in file names:

  • Do not use: " # % & * : < > ? \ / { | } ~
  • File names cannot be longer than 128 characters
  • Do not use the period character consecutively in the middle of a file name. For example, "file..name.docx" is invalid.
  • You cannot use the period character at the end of a file name. For example, “filename..docx” is invalid.
  • You cannot start a file name with the period character
  • Many other symbols are not recommended such as $^()-_=+[]`! (other international currency symbols and international symbols should be avoided in site names, but some are more acceptable in file names. Ascii is preferred when possible.

@adrians5j
Copy link
Owner

adrians5j commented Nov 6, 2019

@kvvinokurov Interesting feature request.

Can you please move this into a separate issue?

Thank you!

@kvvinokurov
Copy link
Author

@kvvinokurov Interesting feature request.

Can you please move this into a separate issue?

Thank you!

ok

@kvvinokurov
Copy link
Author

#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants