Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add useNativeDriver as prop #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add useNativeDriver as prop #12

wants to merge 2 commits into from

Conversation

NickLewry
Copy link

No description provided.

@NickLewry NickLewry mentioned this pull request Jun 11, 2020
Open
@NickLewry
Copy link
Author

Apologies I've just realised theres another PR open that addresses this, although I believe my solution is more flexible so I'll keep it open and it's up to you.

@LucasHimelfarb
Copy link

please, i need this change...

@NickLewry
Copy link
Author

@benadamstyles @mcavaliere @BaseCase could you take a look when you get a chance please?

benadamstyles
benadamstyles approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@benadamstyles benadamstyles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems ok to me, I haven't had the chance to run it though

@NickLewry
Copy link
Author

can you merge @mcavaliere @BaseCase ? thanks

@NickLewry
Copy link
Author

@benadamstyles can we merge this please?

@NickLewry
Copy link
Author

@benadamstyles @mcavaliere @BaseCase one last try

@benadamstyles
Copy link
Contributor

Sorry I don't have write access, I can review but I can't merge!

@RolandasSTRG
Copy link

@BaseCase could you please merge the request?

@xlanor
Copy link

xlanor commented Nov 3, 2020

I forked this and published it to npm, since it's affecting our devs workflows at work. Please let me know if the PR is merged so that I can remove my fork.

@johnbonds
Copy link

+1 on merging this. Pretty please with sugar on top?

@developmentByJuned
Copy link

is it merged ?

@EfeAgare
Copy link

EfeAgare commented Jul 6, 2021

Still waiting for this PR to be merge

@developmentByJuned
Copy link

developmentByJuned commented Jul 6, 2021 via email

@Thanhal-P-A
Copy link

https://www.npmjs.com/package/rn-animated-ellipsis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thanhal-P-A Thanhal-P-A Thanhal-P-A approved these changes

@benadamstyles benadamstyles benadamstyles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@NickLewry @LucasHimelfarb @benadamstyles @RolandasSTRG @xlanor @johnbonds @developmentByJuned @EfeAgare @Thanhal-P-A