Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing rustler build using config doesn't work #151

Closed
Munksgaard opened this issue Jun 6, 2024 · 4 comments
Closed

Forcing rustler build using config doesn't work #151

Munksgaard opened this issue Jun 6, 2024 · 4 comments

Comments

@Munksgaard
Copy link

I'm building my elixir projects as a nix flake, which means that I cannot rely on rustler_precompiled. As suggested in the documentation I tried disabling ruster_precompiled by putting the following in my config.exs (and adding rustler to my deps):

config :rustler_precompiled, :force_build, mjml: true

However, it seems like the explicit setting of force_build in native.ex overrides this option.

@paulgoetze
Copy link
Member

Hey @Munksgaard, thanks for creating this issue. I'll have a look!

paulgoetze added a commit that referenced this issue Jul 10, 2024
Fixes the not picked up config (see #151):
`config :rustler_precompiled, :force_build, mjml: true`
paulgoetze added a commit that referenced this issue Jul 10, 2024
Fixes the not picked up config (see #151):
`config :rustler_precompiled, :force_build, mjml: true`
@paulgoetze
Copy link
Member

It seems to be a special case problem with the config priority in rustler_precompiled.

⏳ Waiting for more info about this in philss/rustler_precompiled#80

@paulgoetze
Copy link
Member

@Munksgaard A new version (v4.0.0) is published which fixes the issue with the config.
(Re the major version Bump: there should be no breaking changes, it just uses mrml v4.0+ and we sync with that.)

@Munksgaard
Copy link
Author

Amazing, thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants