Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix machineInfo curl validation #457

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix machineInfo curl validation #457

merged 1 commit into from
Jul 13, 2023

Conversation

renfeiw
Copy link
Contributor

@renfeiw renfeiw commented Jul 12, 2023

  • update curl version command
  • switch machineInfo detection to warning mode
  • processBuilder to use env copied from the parent shell environment

Fixes #456

@renfeiw
Copy link
Contributor Author

renfeiw commented Jul 12, 2023

grinder: Grinder/33867, Grinder/33868, Grinder/338671, Grinder/338672

@renfeiw renfeiw marked this pull request as ready for review July 12, 2023 19:41
src/org/openj9/envInfo/MachineInfo.java Outdated Show resolved Hide resolved
- update curl version command
- switch machineInfo detection to warning mode
- processBuilder to use env copied from the parent shell environment

Signed-off-by: renfeiw <[email protected]>
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit e77928f into adoptium:master Jul 13, 2023
2 checks passed
@renfeiw
Copy link
Contributor Author

renfeiw commented Jul 13, 2023

fyi @KostasTsiounis

renfeiw added a commit that referenced this pull request Jul 13, 2023
renfeiw added a commit to renfeiw/TKG that referenced this pull request Jul 14, 2023
- based on adoptium#457
- provide fix for NumberFormatException

This reverts commit d59bb56.
renfeiw added a commit to renfeiw/TKG that referenced this pull request Jul 14, 2023
- based on adoptium#457
- provide fix for NumberFormatException

This reverts commit d59bb56.
renfeiw added a commit to renfeiw/TKG that referenced this pull request Jul 14, 2023
- based on adoptium#457
- change back curl version command as it doesn't work for certain machines
- provide fix for NumberFormatException

This reverts commit d59bb56.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing logic for EnvDetector failed to grab CURL information
3 participants