-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix machineInfo curl validation #457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grinder: Grinder/33867, Grinder/33868, Grinder/338671, Grinder/338672 |
karianna
requested changes
Jul 13, 2023
- update curl version command - switch machineInfo detection to warning mode - processBuilder to use env copied from the parent shell environment Signed-off-by: renfeiw <[email protected]>
karianna
approved these changes
Jul 13, 2023
llxia
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fyi @KostasTsiounis |
renfeiw
added a commit
to renfeiw/TKG
that referenced
this pull request
Jul 14, 2023
- based on adoptium#457 - provide fix for NumberFormatException This reverts commit d59bb56.
renfeiw
added a commit
to renfeiw/TKG
that referenced
this pull request
Jul 14, 2023
- based on adoptium#457 - provide fix for NumberFormatException This reverts commit d59bb56.
renfeiw
added a commit
to renfeiw/TKG
that referenced
this pull request
Jul 14, 2023
- based on adoptium#457 - change back curl version command as it doesn't work for certain machines - provide fix for NumberFormatException This reverts commit d59bb56.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #456