You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Both bootstrap 5 and ember-sortable use a .visually-hidden class. This results in styles being applied to an ember-sortable element that can cause layout issues. Particularly because the bootstrap class makes the element absolutely positioned.
To Reproduce
Add ember-bootstrap and ember-sortable to a project. Configure ember-bootstrap to use boostrap 5 and add a sortable-group
Expected behavior
The span does not have additional styles applied from bootstrap
Proposal
I've worked around this in my project by applying more specific styles, however it took me quite some time to track down what was causing a weird behavior in my application so I thought it would help others if this style could be updated to avoid the issue.
I propose renaming .visually-hidden to .ember-sortable-visually-hidden, The class name does not appear to form any part of an external interface so I think it would be a non-breaking change?
Happy to raise a PR for this if the proposal sounds good?
The text was updated successfully, but these errors were encountered:
Describe the bug
Both bootstrap 5 and ember-sortable use a
.visually-hidden
class. This results in styles being applied to anember-sortable
element that can cause layout issues. Particularly because the bootstrap class makes the element absolutely positioned.To Reproduce
Add
ember-bootstrap
andember-sortable
to a project. Configureember-bootstrap
to use boostrap 5 and add asortable-group
This span is added by
ember-sortable
<span aria-live="polite" class="visually-hidden"></span>
Styles for
.visually-hidden
on the span element are (these all come from bootstrap)Expected behavior
The span does not have additional styles applied from bootstrap
Proposal
I've worked around this in my project by applying more specific styles, however it took me quite some time to track down what was causing a weird behavior in my application so I thought it would help others if this style could be updated to avoid the issue.
I propose renaming
.visually-hidden
to.ember-sortable-visually-hidden
, The class name does not appear to form any part of an external interface so I think it would be a non-breaking change?Happy to raise a PR for this if the proposal sounds good?
The text was updated successfully, but these errors were encountered: