Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support flex/grid/margin around the sortable-items #473

Open
NullVoxPopuli opened this issue Apr 12, 2022 · 2 comments · May be fixed by benedikt/ember-sortable#1
Open

Does not support flex/grid/margin around the sortable-items #473

NullVoxPopuli opened this issue Apr 12, 2022 · 2 comments · May be fixed by benedikt/ember-sortable#1

Comments

@NullVoxPopuli
Copy link
Contributor

Describe the bug
When a layout of items is contained within a flex/grid (with gap), and dragging begins, all items collapse the gap via translateY. This is because this code
https://github.com/adopted-ember-addons/ember-sortable/blob/master/addon/modifiers/sortable-group.js#L635-L639
is only calculating translateY from the heights of the surrounding elements, which excludes the gap.

Expected behavior
No shift upon drag-start

@ghost
Copy link

ghost commented Jul 8, 2022

Is there a workaround until this is fixed? I have this exact problem.

@joe-reich
Copy link

I worked around this by adding a margin instead of using flexbox with a gap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants