Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve minDate and maxDate parsing #204

Open
alexlafroscia opened this issue Oct 1, 2018 · 1 comment
Open

Improve minDate and maxDate parsing #204

alexlafroscia opened this issue Oct 1, 2018 · 1 comment
Labels

Comments

@alexlafroscia
Copy link
Member

Currently, it seems like minDate and maxDate both must be Date objects, otherwise things blow up, because getTime is called on whatever is passed in

const _minDate = new Date(minDate.getTime());

const _maxDate = new Date(maxDate.getTime());

I think that, in both cases, the object should first be converted to a Date (or moment object?`) and then the time extracted.

@alexlafroscia
Copy link
Member Author

This seems to be addressed by #188 so I’ll hold off making a fix in favor of allowing that PR to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant