Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all components using ember-composability-tools to glimmer #1292

Open
12 of 20 tasks
matthewhartstonge opened this issue Oct 29, 2024 · 0 comments · Fixed by #1294 or #1293 · May be fixed by #1298, #1299 or #1300
Open
12 of 20 tasks

Convert all components using ember-composability-tools to glimmer #1292

matthewhartstonge opened this issue Oct 29, 2024 · 0 comments · Fixed by #1294 or #1293 · May be fixed by #1298, #1299 or #1300
Assignees
@matthewhartstonge

Comments

@matthewhartstonge
Copy link
Contributor

matthewhartstonge commented Oct 29, 2024 •
edited
Loading

Todo

Mixins

There are a number of mixins that each of these components extend from which will need to be unwound as part of the work.

Parent Components

Children Components

Proxiable Components

Understanding the hierarchy:

Image

native ember

The following on ember-render-modifiers gives an example of how to migrate these components using ember/glimmer native primitives and patterns

https://github.com/emberjs/ember-render-modifiers#example-ember-composability-tools-style-rendering

PR Ordering

I've 'stacked' these PRs to minimise the amount needed to be reviewed, but each item requires the changes made before:
@matthewhartstonge matthewhartstonge converted this from a draft issue Oct 29, 2024
@matthewhartstonge matthewhartstonge changed the title Convert all components using ember-composability-helpers to glimmer Convert all components using ember-composability-tools to glimmer Oct 29, 2024
@matthewhartstonge matthewhartstonge self-assigned this Nov 11, 2024
This was linked to pull requests Nov 11, 2024
feat(addon/components/paper-button): converts to a glimmer component. #1298
Open
chore: remove events mixin. #1294
Merged
chore: remove color mixin. #1293
Merged
feat(addon/components/paper-grid): converts to glimmer components. #1299
Open
feat(addon/components/paper-form): converts to a glimmer component. #1300
Open
feat(addon/components/paper-item): converts to a glimmer component. #1304
Open
feat(addon/components/paper-checkbox): converts to a glimmer component. #1305
Open
feat(addon/components/paper-switch): converts to a glimmer component. #1310
Open
feat(addon/components/paper-radio): converts radio components to glimmer components. #1309
Open
@github-project-automation github-project-automation bot moved this from In progress to Done in ember-paper@v1 release Nov 15, 2024
@matthewhartstonge matthewhartstonge moved this from Done to In progress in ember-paper@v1 release Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewhartstonge matthewhartstonge

Labels
None yet
Projects
ember-paper@v1 release
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove events mixin. adopted-ember-addons/ember-paper
chore: remove color mixin. adopted-ember-addons/ember-paper
feat(addon/components/paper-button): converts to a glimmer component. adopted-ember-addons/ember-paper
feat(addon/components/paper-grid): converts to glimmer components. adopted-ember-addons/ember-paper
feat(addon/components/paper-form): converts to a glimmer component. adopted-ember-addons/ember-paper
feat(addon/components/paper-item): converts to a glimmer component. adopted-ember-addons/ember-paper
feat(addon/components/paper-checkbox): converts to a glimmer component. adopted-ember-addons/ember-paper
feat(addon/components/paper-switch): converts to a glimmer component. adopted-ember-addons/ember-paper
feat(addon/components/paper-radio): converts radio components to glimmer components. adopted-ember-addons/ember-paper
1 participant
@matthewhartstonge