-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip][docs] update docs site design #1152
base: main
Are you sure you want to change the base?
[wip][docs] update docs site design #1152
Conversation
@gabrielcsapo this looks great! |
@miguelcobain glad to hear! Right now we are using LinkTo in the top nav instead of buttons. I was trying to use tabs but the problem is that they do not deal with subrouting correctly. So if you have tab that routes to component and then you are on component.autocomplete it doesn't select it as active. I was trying to work with the logo but it doesn't seem like it fits as the vertical space is too much and the logo itself I tried to convert from |
@miguelcobain I updated the progress picture for one of the component pages! |
This comment has been minimized.
This comment has been minimized.
There is a way to have an I used to have my own helper, but I just found ember-router-helpers: https://github.com/rwjblue/ember-router-helpers Regarding the logo, I guess we need to find an alternative. @Subtletree That wouldn't work because we want the tab to be active for all components, not just a specific one. |
Good point! In that case another option would be a helper Since all the tabs are top level routes. |
@miguelcobain I updated, would you be able to review? |
@miguelcobain 👋 would you let me know if anything needs to be changed? |
@gabrielcsapo I updated the PR so that it uses paper-tabs for the main nav. I still feel that there are some things off.
I'll try to work more on this. |
@miguelcobain just getting back to this as work is less busy. will fix the issues you described, will ping you in discord about the logo! |
fc2b4f1
to
14bf5f9
Compare
@miguelcobain update the text pages so that they are centered and not oddly left aligned. |
I have fixed all outstanding issues except for the logo. @miguelcobain |
@miguelcobain any updates on how we should fix the logo suggestion? |
@miguelcobain if I rebase this and get it running would you be interested in merging it? |
Hey @gabrielcsapo 👋 I'm mostly taking over maintenance of this project at the moment, I haven't had a chance to look at all of the open Issues and PRs yet but I would love to discuss this in more detail with you if you have the time? Are you on the Ember Community Discord? I'm real_ate#4200 on there if you want to reach out and we might arrange a call? |
Motivation
fixes #1149 which focuses on revamping the site design to look like https://getmdl.io/components/index.html.
Comparing two examples side by side we can see that having the example and code condensed together makes things easier to understand:
We can fit more examples in line to allow developers to play around with the variations without having to scroll the entire length of the page to see all iterations.
Todo